When building against pulseaudio >= 2.0, the resulting build does a buffer overflow read with pulseaudio < 2.0

RESOLVED FIXED in Firefox 59

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

a year ago
I know these are old versions of pulseaudio, but as a matter of fact, ubuntu 12.04 is on 1.1, so this is not entirely an hypothetical problem.

We're currently saved because what we ship is built against pulseaudio 0.9.something, which doesn't enable the code that will do the buffer overflow read.
Assignee

Comment 1

a year ago
To make things clearer, this is a problem with the C pulseaudio backend, not with the rust one.
Assignee

Comment 2

a year ago
Oh, and I should mention, the reason this is a going to be a problem is that bug 1399679 is going to change the build environment we use to build Firefox, and that will be using pulseaudio 2.0 headers, which enable the code doing the buffer overflow read.
Blocks: 1399679
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8938924 [details]
Bug 1427150 - Don't get some default sink info based on the pa_sink_info build-time size.

https://reviewboard.mozilla.org/r/209392/#review215150

Thanks.
Attachment #8938924 - Flags: review+
Comment hidden (mozreview-request)
Assignee

Updated

a year ago
Attachment #8938924 - Attachment is obsolete: true
Attachment #8938924 - Flags: review?(padenot)
Assignee

Comment 9

a year ago
As this was merged upstream just on top of what was already the commit used in mozilla-central, I replaced the two patches here with a "Update cubeb from upstream to 43e15fc" that has the same changes, plus an update of README_MOZILLA for the git sha1.

Comment 10

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/69f9bc50da95
Update cubeb from upstream to 43e15fc. r=kamidphish

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/69f9bc50da95
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee

Updated

a year ago
Blocks: 1430506
You need to log in before you can comment on or make changes to this bug.