Closed
Bug 1427150
Opened 5 years ago
Closed 5 years ago
When building against pulseaudio >= 2.0, the resulting build does a buffer overflow read with pulseaudio < 2.0
Categories
(Core :: Audio/Video: cubeb, enhancement)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
I know these are old versions of pulseaudio, but as a matter of fact, ubuntu 12.04 is on 1.1, so this is not entirely an hypothetical problem. We're currently saved because what we ship is built against pulseaudio 0.9.something, which doesn't enable the code that will do the buffer overflow read.
Assignee | ||
Comment 1•5 years ago
|
||
To make things clearer, this is a problem with the C pulseaudio backend, not with the rust one.
Assignee | ||
Comment 2•5 years ago
|
||
Oh, and I should mention, the reason this is a going to be a problem is that bug 1399679 is going to change the build environment we use to build Firefox, and that will be using pulseaudio 2.0 headers, which enable the code doing the buffer overflow read.
Blocks: 1399679
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•5 years ago
|
||
Sent upstream: https://github.com/kinetiknz/cubeb/pull/396
Comment hidden (mozreview-request) |
Comment on attachment 8938924 [details] Bug 1427150 - Don't get some default sink info based on the pa_sink_info build-time size. https://reviewboard.mozilla.org/r/209392/#review215150 Thanks.
Attachment #8938924 -
Flags: review+
Comment on attachment 8938914 [details] Bug 1427150 - Update cubeb from upstream to 43e15fc. https://reviewboard.mozilla.org/r/209380/#review215152
Attachment #8938914 -
Flags: review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•5 years ago
|
Attachment #8938924 -
Attachment is obsolete: true
Attachment #8938924 -
Flags: review?(padenot)
Assignee | ||
Comment 9•5 years ago
|
||
As this was merged upstream just on top of what was already the commit used in mozilla-central, I replaced the two patches here with a "Update cubeb from upstream to 43e15fc" that has the same changes, plus an update of README_MOZILLA for the git sha1.
Comment 10•5 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/69f9bc50da95 Update cubeb from upstream to 43e15fc. r=kamidphish
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/69f9bc50da95
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•