1427163 - Tab moving in the Tab Bar has visual issues

Status: NEW

(Firefox :: Tabbed Browser, defect, P3)

Description

[Mehmet]

Attachment: TabBar_Different_Animations.mov

macOS 10.12.6 (but probably OS=All)
FF58 Beta, FF59.0a1 (2017-12-26) (64-Bit)

It seems that there are still similar issues of fixed bug 1409133 in the following cases:

Case 1) Open a few tabs (e.g. only 4 tabs) and move the very right tab to the very left and the very left tab to the very right.

--> Everything works fine.


Case 2) Open more tabs, so that the tabs start shrinking. Move the very right tab to the very left and the very left tab to the very right. Or move some tabs from the middle to the very left/right.

--> You'll notice that the Favicon and the Tab title jump in the tab after releasing the mouse button.


Case 3) Now open again much more tabs, but so that the Overflow buttons DO NOT appear. Move the very right tab to the very left and the very left tab to the very right. Or move some tabs from the middle to the very left/right

--> You'll notice that the tab will jump at all after finishing the drag/drop animation.

A screencast is attached. If you have questions, please let me know.

Thanks!

Comment 1

[Mehmet]

+Johann, because of related bug 1409133.

Comment 2

[Alice0775 White]

I can reproduce the issue on Windows10

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e9648ee6c4ffa7dfaeb70c5e95f5634f2ed9531c&tochange=e9227aaffbe730655b1416767672d504e144d56c

Regressed by: e9227aaffbe7	Tim Taubert — Bug 1396833 - Fix tab drag&drop not finishing due to CSS transform not kicking in r=mconley

Comment 3

[Mike Taylor [:miketaylr]]

ni? Tim for the regressing patch. But given P3, I don't think we should block releases on this.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

I probably won't find the time to look into the regression. The flickering seems better than a broken tabbar that's only fixable by a restart, so it seems we shouldn't back this out. But then, the visual issue reported here occurs on every drop, IIUIC. Maybe what's needed is a different approach. Maybe we shouldn't wait for "transitionend". I hope someone can pick this up.

Comment 5

[apkwa]

(In reply to Tim Taubert [:ttaubert] (inactive) from comment #4)

I probably won't find the time to look into the regression. The flickering
seems better than a broken tabbar that's only fixable by a restart, so it
seems we shouldn't back this out. But then, the visual issue reported here
occurs on every drop, IIUIC. Maybe what's needed is a different approach.
Maybe we shouldn't wait for "transitionend". I hope someone can pick this up.

Thanks for your reply, i was facing the same issue while using https://apkwa.net/tm-whatsapp/ now it's resollved.