1427205 - Can't Remove Matrix Accounts

Status: RESOLVED FIXED

(Chat Core :: Matrix, defect)

Description

[Ryan Lee Sipes]

Attachment: List of Matrix chat Accounts

At one point I tried adding a Matrix account and (because of issues I had ended up trying to add it three different ways). But I'm having an issue removing these accounts now.

I can remove them from the list of chat accounts but upon restarting TB they are all back.

Comment 1

[Patrick Cloke [:clokep]]

Yes, this is a bug. Someone needs to track down what's happening.

I suspect an error is being thrown somewhere (error console?) that has what the issue is.

Comment 2

[Ryan Lee Sipes]

Hey Patrick, can you walk me through how to track down this error in the console so I can report it here?

Comment 3

[Patrick Cloke [:clokep]]

Oops, I apparently never got around to this. I think it was mentioned in a few other places, but we need to integrate the new Matrix JS package before working on this more.

(In reply to Ryan Sipes from comment #2)

Hey Patrick, can you walk me through how to track down this error in the
console so I can report it here?

To answer your question though, there are two places to check:

1. Click "Show Accounts" when on the "Chat" tab.
2. Right click on the account in question.
3. Click "Copy Debug Log". The debug log has a bunch of technical information that might have been logged by the protocol code. Some of it could be sensitive.
4. Alternately, you can look in the error console, accessible via the menus: "Tools" > "Developer Tools" > "Error Console"
5. It is best to click "Clear" (the little trash can icon on the top left) and then perform whatever you expect to work to see if any NEW errors pop up.

Comment 4

[Mayeul C]

This needs to be moved to the Matrix component (and perhaps bugs 1498978 and 1315926 as well?)

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Patch

Comment 6

[Patrick Cloke [:clokep]]

I should probably state that this changes the Matrix code to not through an error...but it also doesn't properly clean-up after itself. I think that's an improvement for now. It'll at least work properly to delete the account now.

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9099573 [details] [diff] [review]
Patch

Review of attachment 9099573 [details] [diff] [review]:
-----------------------------------------------------------------

r+ based on comment 6.

::: chat/protocols/matrix/matrix.js
@@ +102,5 @@
>  }
>  MatrixAccount.prototype = {
>    __proto__: GenericAccountPrototype,
>    observe(aSubject, aTopic, aData) {},
> +  remove() {},

Maybe add a couple of TODO comments here saying that this needs to be extended at some point?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4e21ee135e91
Fix removing and shutting down Matrix accounts. r=nhnt11

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 9099573 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: Users are not able to remove a Matrix account (which they can only create by messing with preferences).
Testing completed (on c-c, etc.): This has been on c-c for a bit.
Risk to taking this patch (and alternatives if risky): Matrix is not enabled by default, so I don't think there's much risk to taking this patch.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 9099573 [details] [diff] [review]
Patch

Sure, thanks.

Comment 11

[Jorg K (CEST = GMT+2)]

TB 68.2.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/8ba6b3a01467f28d48da6f422738ac081e5bdf1b