1427210 - Move check-sync tests to a separate task, so that builds don't immediately fail when there are trivial changes

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Tom Prince [:tomprince]]

Right now, the checks are part of `make check` which means that builds fail whenever changes are made to files that check-sync-dirs.py looks at. For taskcluster builds in particular, this means that test don't get run.

Instead, we should move those checks to a separate task that can fail independently, which means that changes that don't cause build breakage aren't on the critical path of keeping thunderbird building.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1427210: Fix flake8 errors in check-sync-dirs.py;

There are some remaning line-to-long errors, but they will be cleaned up later
in this series.

Review commit: https://reviewboard.mozilla.org/r/209410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209410/

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1427210: Since we are using python 2.7, we can use a set instead of simulating it with a dictionary;

Review commit: https://reviewboard.mozilla.org/r/209412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209412/

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1427210: Use python docstrings;

Review commit: https://reviewboard.mozilla.org/r/209422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209422/

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1427210: Use mozlog for outputting check-sync test results;

Review commit: https://reviewboard.mozilla.org/r/209414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209414/

Comment 5

[Tom Prince [:tomprince]]

Attachment: Bug 1427210: Run check-sync-dirs.py as seperate task;

Review commit: https://reviewboard.mozilla.org/r/209416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209416/

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8938970 [details]
Bug 1427210: Fix flake8 errors in check-sync-dirs.py;

https://reviewboard.mozilla.org/r/209410/#review215224

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8938971 [details]
Bug 1427210: Since we are using python 2.7, we can use a set instead of simulating it with a dictionary;

https://reviewboard.mozilla.org/r/209412/#review215226

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8938972 [details]
Bug 1427210: Use python docstrings;

https://reviewboard.mozilla.org/r/209422/#review215228

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8938973 [details]
Bug 1427210: Use mozlog for outputting check-sync test results;

https://reviewboard.mozilla.org/r/209414/#review215230

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8938974 [details]
Bug 1427210: Run check-sync-dirs.py as seperate task;

https://reviewboard.mozilla.org/r/209416/#review215232

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f8693edcab2b
Fix flake8 errors in check-sync-dirs.py; r=Fallen
https://hg.mozilla.org/comm-central/rev/158d7aebb584
Since we are using python 2.7, we can use a set instead of simulating it with a dictionary; r=Fallen
https://hg.mozilla.org/comm-central/rev/cf81f9130dd3
Use python docstrings; r=Fallen
https://hg.mozilla.org/comm-central/rev/4474dbcf45b8
Use mozlog for outputting check-sync test results; r=Fallen
https://hg.mozilla.org/comm-central/rev/048f5041c991
Run check-sync-dirs.py as seperate task; r=Fallen

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4469c475c6b4
Move check-sync task to `lint` platform; r=me