Closed Bug 1427210 Opened 3 years ago Closed 3 years ago

Move check-sync tests to a separate task, so that builds don't immediately fail when there are trivial changes

Categories

(Thunderbird :: Build Config, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tomprince, Assigned: tomprince)

Details

Attachments

(5 files)

Right now, the checks are part of `make check` which means that builds fail whenever changes are made to files that check-sync-dirs.py looks at. For taskcluster builds in particular, this means that test don't get run.

Instead, we should move those checks to a separate task that can fail independently, which means that changes that don't cause build breakage aren't on the critical path of keeping thunderbird building.
Comment on attachment 8938970 [details]
Bug 1427210: Fix flake8 errors in check-sync-dirs.py;

https://reviewboard.mozilla.org/r/209410/#review215224
Attachment #8938970 - Flags: review?(philipp) → review+
Comment on attachment 8938971 [details]
Bug 1427210: Since we are using python 2.7, we can use a set instead of simulating it with a dictionary;

https://reviewboard.mozilla.org/r/209412/#review215226
Attachment #8938971 - Flags: review?(philipp) → review+
Comment on attachment 8938972 [details]
Bug 1427210: Use python docstrings;

https://reviewboard.mozilla.org/r/209422/#review215228
Attachment #8938972 - Flags: review?(philipp) → review+
Comment on attachment 8938973 [details]
Bug 1427210: Use mozlog for outputting check-sync test results;

https://reviewboard.mozilla.org/r/209414/#review215230
Attachment #8938973 - Flags: review?(philipp) → review+
Comment on attachment 8938974 [details]
Bug 1427210: Run check-sync-dirs.py as seperate task;

https://reviewboard.mozilla.org/r/209416/#review215232
Attachment #8938974 - Flags: review?(philipp) → review+
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/f8693edcab2b
Fix flake8 errors in check-sync-dirs.py; r=Fallen
https://hg.mozilla.org/comm-central/rev/158d7aebb584
Since we are using python 2.7, we can use a set instead of simulating it with a dictionary; r=Fallen
https://hg.mozilla.org/comm-central/rev/cf81f9130dd3
Use python docstrings; r=Fallen
https://hg.mozilla.org/comm-central/rev/4474dbcf45b8
Use mozlog for outputting check-sync test results; r=Fallen
https://hg.mozilla.org/comm-central/rev/048f5041c991
Run check-sync-dirs.py as seperate task; r=Fallen
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/4469c475c6b4
Move check-sync task to `lint` platform; r=me
You need to log in before you can comment on or make changes to this bug.