Closed Bug 1427337 Opened 6 years ago Closed 6 years ago

Fix build config from the fallout of bug 1426758.

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.56

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(2 files, 1 obsolete file)

the mention of mozconfig.gtk in mozconfig.linux in build/unix was
removed due to bug 1426785.  So now we need to include mozconfig.gtk
in our linux* mozconfigs.
Attached patch [mozconfigs] proposed patch (obsolete) — Splinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8939056 - Flags: review?(frgrahl)
Comment on attachment 8939056 [details] [diff] [review]
[mozconfigs] proposed patch

Would it be ok to put the include on top as in the normal mozconfigs.

r+ with that fixed or answered.
Attachment #8939056 - Flags: review?(frgrahl) → review+
Attachment #8939056 - Attachment is obsolete: true
Attachment #8939062 - Flags: review+
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/dc0dd2176490
Fix build config bustage from the fallout from bug 1426758 r=frg
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Seamonkey2.56
l10n repacks also need this change.  Since we're adding so much
stuff that are common to all the l10n mozconfigs, I figure putting them
in mozconfig.linux.l10n.common would make more sense.
Attachment #8939129 - Flags: review?(frgrahl)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8939129 [details] [diff] [review]
[mozconfigs] proposed l10n mozconfig changes

Looks good and simplifies the configs. r+
Attachment #8939129 - Flags: review?(frgrahl) → review+
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/058aa6495c2d
Add mozconfig.linux.l10n.common for l10n repacks r=frg
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Pushed by ewong@pw-wspx.org:
https://hg.mozilla.org/comm-central/rev/4dc0b697b15d
debug build requires mozconfig.linux.common. r=bustagefix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: