1427407 - Add Add-ons Options menu item to the Menu button

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[WaltS48 [:walts48]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171229220051

Steps to reproduce:

After bug 1419145 landed there is a menu item under Tools in the Menu bar, titled Add-ons Options.
Selecting it opens a sub-menu to the right of the > with a list of extensions with preferences.
This is missing from the Menu button.


Actual results:

Using the Menu button and selecting Add-ons shows a list of extensions with preferences, but it blocks access to opening the Add-ons manager.


Expected results:

I think a separate Add-ons Options menu item should be listed under the Menu button, like it is for Tools in the Menu bar.
Users will go to select Add-ons in the Menu button, and be confused as to why they are seeing a list of extensions.

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for filing the bug!

Comment 2

[:aceman]

Attachment: 1427407.patch

This could do it. Adds the add-ons as the first item in the submenu, as seems the style (and necessity) also in other such <splitmenu>s in the appmenu.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 8939162 [details] [diff] [review]
1427407.patch

Review of attachment 8939162 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8939162 [details] [diff] [review]
1427407.patch

Review of attachment 8939162 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWindowOverlay.js
@@ +3715,5 @@
>   *  @option aMenupopup  The menupopup element to populate.
>   */
>  function initAddonPrefsMenu(aMenupopup) {
> +  // Clear all but the special menuitems on top.
> +  let noPrefsElem = aMenupopup.querySelector('[disabled="true"]');

Actually, I'm looking at this and I don't understand it.
The comment says: Clear all but the special menuitems on top.
So it refers to a plural. So which items are they?
Are they always disabled? I thought the "no add-ons here" is sometimes enabled.
The variable holds a single reference, so that doesn't match the comment.

Comment 5

[:aceman]

(In reply to Jorg K (GMT+1) from comment #4)
> Actually, I'm looking at this and I don't understand it.
> The comment says: Clear all but the special menuitems on top.
> So it refers to a plural. So which items are they?
In the main menu, there is only one special item (the "no add-on prefs" one, disabled), in the appmenu there are 3:
add-on manager, menuseparator, the "no add-on prefs" item (disabled).

The loop is removing element bottom up and we need it to stop on the special items. So I based the check on hitting the disabled=true item, which is the "no add-on prefs", currently.

> Are they always disabled? I thought the "no add-ons here" is sometimes
> enabled.

It is never enabled (you can't click it), it is just collapsed (hidden) as needed.

> The variable holds a single reference, so that doesn't match the comment.

Yes, it is the single element that is the last one of the special ones. On this boundary the clearing loop has to stop.

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #5)
> The loop is removing element bottom up and we need it to stop on the special
> items. So I based the check on hitting the disabled=true item, which is the
> "no add-on prefs", currently.
OK, very tricky, could you document this, please.

Something like:
// Starting at the bottom, clear all menu items until we hit
// "no add-on prefs" which is disabled. On the app menu there could be
// further items above it like a separator and the add-ons manager entry.

Comment 7

[:aceman]

Attachment: 1427407.patch v1.1

Thanks, done.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2639c3ea8ba0
add "Add-ons" menuitem in the Add-ons submenu of appmenu. ui-r=Paenglab, r=Paenglab

Comment 9

[WaltS48 [:walts48]]

This is still confusing.

The user uses the Menu Button > Add-ons, and after a slight delay sees a list of extensions with no understanding of why they are there.

Comment 10

[Jorg K (CEST = GMT+2)]

This is shipping now in TB 59 beta, so no point to leave the bug open. In fact, my query didn't find the bug when I was looking for bugs that need to go into the release notes :-(

If you're not happy with the solution, please file another bug.