1427505 - Move c-c specific, static definitions from confvars.sh/configure.in to moz.configure.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1427505: Get rid of always-set `MOZ_COMPOSER` configuration;

Review commit: https://reviewboard.mozilla.org/r/209696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209696/

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1427505: Get rid of setting MOZ_LDAP_XPCOM from configure.in;

It is now set in `moz.configure`.

Review commit: https://reviewboard.mozilla.org/r/209698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209698/

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1427505: Move MOZ_MOVEMAIL configuration to moz.configure;

Review commit: https://reviewboard.mozilla.org/r/209700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209700/

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1427505: Move `MOZ_SEPARATE_MANIFEST_FOR_THEME_OVERRIDES` to moz.configure;

Review commit: https://reviewboard.mozilla.org/r/209702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209702/

Comment 5

[Tom Prince [:tomprince]]

Attachment: Bug 1427505: Move `MOZ_THUNDERBIRD` to `moz.configure`;

Review commit: https://reviewboard.mozilla.org/r/209704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209704/

Comment 6

[Tom Prince [:tomprince]]

Attachment: Bug 1427505: Move `MOZ_SUITE` to `moz.configure`;

Review commit: https://reviewboard.mozilla.org/r/209706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209706/

Comment 7

[Tom Prince [:tomprince]]

Comment on attachment 8939267 [details]
Bug 1427505: Move MOZ_MOVEMAIL configuration to moz.configure;

https://reviewboard.mozilla.org/r/209700/#review215252

::: mailnews/moz.configure:56
(Diff revision 1)
>  
>  set_config('MOZ_MAPI_SUPPORT', mapi_support)
>  set_define('MOZ_MAPI_SUPPORT', mapi_support)
>  
> +set_config('MOZ_MOVEMAIL', target_is_unix)
> +set_define('HAVE_MOVEMAIL', target_is_unix)

This is [the same](https://dxr.mozilla.org/mozilla-central/rev/e02699fd3129bef049f848e2f71189182eabe555/build/moz.configure/init.configure#882-885)  conditional.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8939265 [details]
Bug 1427505: Get rid of always-set `MOZ_COMPOSER` configuration;

https://reviewboard.mozilla.org/r/209696/#review215256

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8939266 [details]
Bug 1427505: Get rid of setting MOZ_LDAP_XPCOM from configure.in;

https://reviewboard.mozilla.org/r/209698/#review215258

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8939267 [details]
Bug 1427505: Move MOZ_MOVEMAIL configuration to moz.configure;

https://reviewboard.mozilla.org/r/209700/#review215260

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8939268 [details]
Bug 1427505: Move `MOZ_SEPARATE_MANIFEST_FOR_THEME_OVERRIDES` to moz.configure;

https://reviewboard.mozilla.org/r/209702/#review215262

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8939269 [details]
Bug 1427505: Move `MOZ_THUNDERBIRD` to `moz.configure`;

https://reviewboard.mozilla.org/r/209704/#review215264

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8939270 [details]
Bug 1427505: Move `MOZ_SUITE` to `moz.configure`;

https://reviewboard.mozilla.org/r/209706/#review215266

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8939265 [details]
Bug 1427505: Get rid of always-set `MOZ_COMPOSER` configuration;

Happy New Year r+

Comment 15

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8939267 [details]
Bug 1427505: Move MOZ_MOVEMAIL configuration to moz.configure;

It seems MOVEMAIL is always defined. Does it still make sense to be an optional component?

Comment 16

[Jorg K (CEST = GMT+2)]

(In reply to Frank-Rainer Grahl (:frg) from comment #15)
> It seems MOVEMAIL is always defined. Does it still make sense to be an
> optional component?
Sorry, I don't even understand the question. Are you referring to the HAVE_MOVEMAIL?

Comment 17

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8939267 [details]
Bug 1427505: Move MOZ_MOVEMAIL configuration to moz.configure;

> Sorry, I don't even understand the question. Are you referring to the HAVE_MOVEMAIL?

Jork, yes I mean MOZ_MOVEMAIL.

Comment 18

[Frank-Rainer Grahl (:frg)]

Jorgk of course.

Comment 19

[Jorg K (CEST = GMT+2)]

Hmm, I thought MOVEMAIL is for Linux only, I've never seen it.

Comment 20

[Tom Prince [:tomprince]]

> It seems MOVEMAIL is always defined.

It isn't. It is only defined on Linux/macOS (i.e. when target_is_unix is true).

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e6ab2f1c372f
Get rid of always-set `MOZ_COMPOSER` configuration; r=Fallen,frg
https://hg.mozilla.org/comm-central/rev/395185d63193
Get rid of setting MOZ_LDAP_XPCOM from configure.in; r=Fallen,frg
https://hg.mozilla.org/comm-central/rev/abd3ecd7c46d
Move MOZ_MOVEMAIL configuration to moz.configure; r=Fallen,frg
https://hg.mozilla.org/comm-central/rev/e60b3d52d364
Move `MOZ_SEPARATE_MANIFEST_FOR_THEME_OVERRIDES` to moz.configure; r=Fallen,frg
https://hg.mozilla.org/comm-central/rev/2b8273008442
Move `MOZ_THUNDERBIRD` to `moz.configure`; r=Fallen
https://hg.mozilla.org/comm-central/rev/7774e765fe5f
Move `MOZ_SUITE` to `moz.configure`; r=frg

Comment 22

[Frank-Rainer Grahl (:frg)]

> It isn't. It is only defined on Linux/macOS (i.e. when target_is_unix is true)

Thanks. Looked via dxr and didn't notice this.

FRG