Closed
Bug 1427519
Opened 7 years ago
Closed 7 years ago
remove inCSSValueSearch and related interfaces
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
It looks like inCSSValueSearch isn't used any more.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → cam
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8939285 [details]
Bug 1427519 - Remove unused inCSSValueSearch and related interfaces.
https://reviewboard.mozilla.org/r/209718/#review215544
Thanks for doing this cleanup!
From what I could find, I don't believe these interfaces were ever used by the built-in DevTools or the Firebug add-on. Instead, it looks like they were added for the DOM Inspector add-on, but then that usage code was removed in bug 378696 (~11 years ago).
Attachment #8939285 -
Flags: review?(jryans) → review+
|
||
Comment 4•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 1abeee653534 -d f9d423919e3f: rebasing 440645:1abeee653534 "Bug 1427519 - Remove unused inCSSValueSearch and related interfaces. r=jryans" (tip)
merging layout/build/nsLayoutModule.cpp
merging layout/inspector/moz.build
warning: conflicts while merging layout/build/nsLayoutModule.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging layout/inspector/moz.build! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/197ceff072eb
Remove unused inCSSValueSearch and related interfaces. r=jryans
|
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•