1427680 - select or highlight the text in the article causes the text invisible (due to missing ::-moz-selection rule)

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Ya-Chieh Wu (inactive)]

User agent:
FF 57.0.3 (64-bit)
MACOS

Steps to reproduce:

1. load an article from https://www.businesstoday.com.tw/article/category/80392/post/201712250014
2. select or highlight the texts in the article

result: the selected texts are unreadable
expected result: the selected texts are highlight

Comment 1

[Ya-Chieh Wu (inactive)]

Attachment: webpage.zip

backup the page

Comment 2

[Emilio Cobos Álvarez (:emilio)]

The page has a ::selection { background-color: <some-red> }, but no ::-moz-selection equivalent.

I wonder if we should just unprefix ::-moz-selection.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Cam, wdyt of unprefixing ::-moz-selection, aliasing ::-moz-selection to ::selection at parse-time?

We could do the same as for ::placeholder, where we keep both, but honestly I expected to be able to remove the complexity ::placeholder introduces eventually (maybe at the same time?).

Comment 4

[Cameron McCormack (:heycam)]

What's the status and interoperability of ::selection in other browsers, and how well does our implementation match what's in css-pseudo-4 right now?  That information should help us decide whether to unprefix as is.

https://drafts.csswg.org/css-pseudo-4/#highlight-selectors

Comment 5

[Emilio Cobos Álvarez (:emilio)]

So, re. css-pseudo-4, the spec doesn't say much. We don't support ::inactive-selection, but nor do other browsers that ship it unprefixed.

I don't know of any interop issues with the current ::selection implementation. I've searched a bit bugzilla and such and no relevant bugs, and caniuse[1] only mentions in known issues:

> In Safari ::selection styles do not work in combination with CSS multi-column.

[1]: https://caniuse.com/#feat=css-selection

Comment 6

[Cameron McCormack (:heycam)]

It would be good to see some tests just to confirm that we are implementing what the other browsers do, particularly in terms of which properties are supported in ::selection (which I think would be the biggest potential source of compat issues).

David may also remember whether there's any particular reason we haven't already unprefixed.

Comment 7

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Fixed in bug 509958.