SM: Restore the dialogheader binding and its styling after the removal in bug 1419600

ASSIGNED
Assigned to

Status

SeaMonkey
General
ASSIGNED
18 days ago
41 minutes ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

(Blocks: 1 bug)

Trunk
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

13 days ago
I have patches for this, just need to test a bit.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
(Assignee)

Comment 2

12 days ago
Created attachment 8941136 [details] [diff] [review]
Part 1: Use the c-c dialogheader binding
Attachment #8941136 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 3

12 days ago
Created attachment 8941140 [details] [diff] [review]
Part 2: Add missing style rules for Modern theme

header-large is only used in the profile selection dialog, so lets stop using that and move those rules to profile.css. Also, I think we should only have style rules in global.css for stuff that has toolkit bindings / style rules.
Attachment #8941140 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 4

12 days ago
Created attachment 8941143 [details] [diff] [review]
Part 3: Copy windows profile.css to classic/mac/communicator/profile/
(Assignee)

Comment 5

12 days ago
Created attachment 8941144 [details] [diff] [review]
Part 4: Add missing style rules for the Classic theme
Attachment #8941144 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

12 days ago
Attachment #8941143 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 6

12 days ago
Created attachment 8941145 [details] [diff] [review]
Part 5: Remove the now obsolete 'header-large' class from profileSelection.xul
Attachment #8941145 - Flags: review?(iann_bugzilla)
Blocks: 1420718

Comment 7

an hour ago
Comment on attachment 8941136 [details] [diff] [review]
Part 1: Use the c-c dialogheader binding

r=me
Attachment #8941136 - Flags: review?(iann_bugzilla) → review+

Comment 8

an hour ago
Comment on attachment 8941140 [details] [diff] [review]
Part 2: Add missing style rules for Modern theme

r=me
Attachment #8941140 - Flags: review?(iann_bugzilla) → review+

Comment 9

43 minutes ago
Comment on attachment 8941143 [details] [diff] [review]
Part 3: Copy windows profile.css to classic/mac/communicator/profile/

r=me
Attachment #8941143 - Flags: review?(iann_bugzilla) → review+

Comment 10

42 minutes ago
Comment on attachment 8941144 [details] [diff] [review]
Part 4: Add missing style rules for the Classic theme

r=me
Attachment #8941144 - Flags: review?(iann_bugzilla) → review+

Updated

41 minutes ago
Attachment #8941145 - Flags: review?(iann_bugzilla) → review+
You need to log in before you can comment on or make changes to this bug.