Remove the dialogheader binding

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P5
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bgrins, Assigned: dao)

Tracking

(Blocks 1 bug)

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

(Whiteboard: [xbl-available])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
The "dialogheader" binding is bound to dialogheader elements: 

- https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/dist/bin/chrome/toolkit/content/global/bindings/dialog.xml#425
- https://dxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#1056

The only consumer of dialogheader in m-c appears to be in optionsDialog: 

- https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/optionsDialog.xml#20
- https://dxr.mozilla.org/mozilla-central/search?q=dialogheader

Note that comm-central does use this binding: https://dxr.mozilla.org/comm-central/search?q=dialogheader, so it should be migrated there (depends on the decision at https://bugzilla.mozilla.org/show_bug.cgi?id=1419179#c2 as far as where it would go)

Once optionsDialog is removed (Bug 1419596), we should be able to remove dialogheader and associated CSS

Updated

a year ago
Priority: -- → P5
(Reporter)

Updated

a year ago
Whiteboard: [xbl-available]
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
(Reporter)

Comment 2

a year ago
mozreview-review
Comment on attachment 8939635 [details]
Bug 1419600 - Remove the dialogheader binding.

https://reviewboard.mozilla.org/r/209940/#review215534

Looks good - thanks!
Attachment #8939635 - Flags: review?(bgrinstead) → review+

Updated

a year ago
Depends on: 1427864

Updated

a year ago
Depends on: 1427865

Comment 3

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96be4341e6a3
Remove the dialogheader binding. r=bgrins

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/96be4341e6a3
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.