1419600 - Remove the dialogheader binding

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, task, P5)

Description

[Brian Grinstead [:bgrins]]

The "dialogheader" binding is bound to dialogheader elements: 

- https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-pc-linux-gnu/dist/bin/chrome/toolkit/content/global/bindings/dialog.xml#425
- https://dxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#1056

The only consumer of dialogheader in m-c appears to be in optionsDialog: 

- https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/optionsDialog.xml#20
- https://dxr.mozilla.org/mozilla-central/search?q=dialogheader

Note that comm-central does use this binding: https://dxr.mozilla.org/comm-central/search?q=dialogheader, so it should be migrated there (depends on the decision at https://bugzilla.mozilla.org/show_bug.cgi?id=1419179#c2 as far as where it would go)

Once optionsDialog is removed (Bug 1419596), we should be able to remove dialogheader and associated CSS

Comment 1

[Dão Gottwald [::dao]]

Attachment: Bug 1419600 - Remove the dialogheader binding.

Review commit: https://reviewboard.mozilla.org/r/209940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/209940/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8939635 [details]
Bug 1419600 - Remove the dialogheader binding.

https://reviewboard.mozilla.org/r/209940/#review215534

Looks good - thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96be4341e6a3
Remove the dialogheader binding. r=bgrins

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/96be4341e6a3