Closed
Bug 1428264
Opened 6 years ago
Closed 6 years ago
Do not show chrome urls in storage inspector
Categories
(DevTools :: Storage Inspector, defect, P2)
DevTools
Storage Inspector
Tracking
(firefox61 verified)
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | verified |
People
(Reporter: tt, Assigned: miker)
Details
Attachments
(2 files)
STR to reproduce: 1. open a tab 2. navigate it to a chrome or file URL (say chrome://browser/content/robot.ico) 3. open the storage inspector 4. Then, take a look at the showing origin in the storage inspector Actual results: "chrome:/content/robot.ico" Expect results: Not pretty sure about what the expected URL is, but I believe it should be either "chrome:///content/robot.ico" or "chrome://browser/content/robot.ico". It seems like current method doesn't take care of an URL without authority (e.g. file:///path-to-file)?
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Has STR: --- → yes
Priority: -- → P2
Assignee | ||
Comment 2•6 years ago
|
||
file:// URLs were fixed in bug 1381590. Experimenting with chrome:// URLs it is clear that no storage types are supported so we shouldn't show chrome:// domains in the storage inspector.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
OS: Unspecified → All
Hardware: Unspecified → All
Assignee | ||
Updated•6 years ago
|
Summary: Support file & chrome url for storage inspector → Support chrome url for storage inspector
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8959547 [details] Bug 1428264 - Do not show chrome urls in storage inspector https://reviewboard.mozilla.org/r/228350/#review234636 ::: commit-message-47e17:1 (Diff revision 1) > +Bug 1428264 - Support chrome urls for storage inspector r?pbro The commit message should be rephrased then. If no storage is supposed on chrome:// urls, then the commit shouldn't say that "support chrome urls", but more something like "don't attempt to support chrome urls"
Attachment #8959547 -
Flags: review?(pbrosset) → review+
Assignee | ||
Updated•6 years ago
|
Summary: Support chrome url for storage inspector → Do not show chrome urls in storage inspector
Comment hidden (mozreview-request) |
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea23c2dda34a Do not show chrome urls in storage inspector r=pbro
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea23c2dda34a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 8•6 years ago
|
||
I have reproduced this bug with Nightly 59.0a1 (2018-01-04) on Windows 10 , 64 Bit ! This bug's fix is Verified with latest Nightly ! Build ID 20180327105613 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0 [bugday-20180321]
Comment 9•6 years ago
|
||
I have reproduced this bug with Nightly 59.0a1 (2018-01-04) on Ubuntu 16.04 LTS! This bug's fix is Verified with latest Nightly ! Build ID 20180331101347 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
QA Whiteboard: [bugday-20180328]
Comment 10•6 years ago
|
||
As per comment 8 and comment 9 , I am marking this bug as Verified Fixed!
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•