1428264 - Do not show chrome urls in storage inspector

Status: VERIFIED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[Tom Tung [:tt, :ttung]]

STR to reproduce:

1. open a tab
2. navigate it to a chrome or file URL (say chrome://browser/content/robot.ico)
3. open the storage inspector
4. Then, take a look at the showing origin in the storage inspector

Actual results:
"chrome:/content/robot.ico"

Expect results:
Not pretty sure about what the expected URL is, but I believe it should be either
"chrome:///content/robot.ico" or "chrome://browser/content/robot.ico".

It seems like current method doesn't take care of an URL without authority (e.g. file:///path-to-file)?

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Screen Shot 2018-01-05 at 11.28.38.png

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

file:// URLs were fixed in bug 1381590.

Experimenting with chrome:// URLs it is clear that no storage types are supported so we shouldn't show chrome:// domains in the storage inspector.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1428264 - Do not show chrome urls in storage inspector

On investigation it turns out that no storage types are supported for chrome:// urls.

Review commit: https://reviewboard.mozilla.org/r/228350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228350/

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8959547 [details]
Bug 1428264 - Do not show chrome urls in storage inspector

https://reviewboard.mozilla.org/r/228350/#review234636

::: commit-message-47e17:1
(Diff revision 1)
> +Bug 1428264 - Support chrome urls for storage inspector r?pbro

The commit message should be rephrased then. If no storage is supposed on chrome:// urls, then the commit shouldn't say that "support chrome urls", but more something like "don't attempt to support chrome urls"

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8959547 [details]
Bug 1428264 - Do not show chrome urls in storage inspector

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228350/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea23c2dda34a
Do not show chrome urls in storage inspector r=pbro

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ea23c2dda34a

Comment 8

[Sajedul Islam]

I have reproduced this bug with Nightly 59.0a1 (2018-01-04) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180327105613
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180321]

Comment 9

[Md Maruf Rahman]

I have reproduced this bug with Nightly 59.0a1 (2018-01-04) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Nightly !

Build   ID    20180331101347
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Comment 10

[Sajedul Islam]

As per comment 8 and comment 9 , I am marking this bug as Verified Fixed!