1428276 - Make ExpectedOwnerForChild deal with abs.pos. anon boxes

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Chih-Hsuan Kuo [:tommykuo]]

Like Bug 1423761, I think we should also use `GetInFlowParent()` in `ExpectedOwnerForChild()` to make sure that we can find the correct parent of style context for an OOF frame.

Comment 1

[Chih-Hsuan Kuo [:tommykuo]]

Attachment: Bug 1428276 - Make ExpectedOwnerForChild deal with abs.pos. anon boxes.

For an OOF frame, the parent frame that's associated with our parent
style context is the *placeholder's* parent -- not the OOF frame's
parent.

Review commit: https://reviewboard.mozilla.org/r/210374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210374/

Comment 2

[Chih-Hsuan Kuo [:tommykuo]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87ad1d13070b81aebbb9a043f006e944462627fc

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8940089 [details]
Bug 1428276 - Make ExpectedOwnerForChild deal with abs.pos. anon boxes.

https://reviewboard.mozilla.org/r/210374/#review216548

::: layout/base/ServoRestyleManager.cpp:110
(Diff revision 1)
>        const nsIFrame* tableFrame = parent->PrincipalChildList().FirstChild();
>        MOZ_ASSERT(tableFrame->IsTableFrame());
>        // Handle :-moz-table and :-moz-inline-table.
>        parent = IsAnonBox(*tableFrame) ? parent->GetParent() : tableFrame;
>      } else {
> -      parent = parent->GetParent();
> +      parent = parent->GetInFlowParent();

Can you add a comment here saying that it's the in-flow parent we need to use, so that we correctly handle OOF anonymous boxes?

Comment 4

[Chih-Hsuan Kuo [:tommykuo]]

Comment on attachment 8940089 [details]
Bug 1428276 - Make ExpectedOwnerForChild deal with abs.pos. anon boxes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210374/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a30d386b21a
Make ExpectedOwnerForChild deal with abs.pos. anon boxes. r=heycam

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7a30d386b21a