1429018 - Add spotlight support to Form Autofill dropdown footer

Status: RESOLVED DUPLICATE of bug 1497523

(Toolkit :: Form Autofill, enhancement, P2)

Description

[Scott Wu [:scottwu]]

The Spotlight feature makes it possible to open and highlight a section in preferences:
about:preferences#privacy-address-autofill

Form Autofill dropdown footer should implement this feature.

Comment 1

[Ray Lin[:ralin]]

Attachment: Bug 1429018 - (WIP) Open preferences with highlighted section via autofill dropdown.

TODO:
1. add test cases to verify the opened url for both credit card and
address
2. make click handler able to distinguish between two types of focused
field.

Review commit: https://reviewboard.mozilla.org/r/211970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211970/

Comment 2

[Maxim Kupfer]

Would this create a conflict if the form was asking for both: credit card and address details?

Comment 3

[Matthew N. [:MattN]]

No, it shouldn't because addresses are autofilled separately from credit cards. e.g. see https://luke-chang.github.io/autofill-demo/multiple_sections/section_heuristics.html where each section gets their own autocomplete dialog.

Comment 4

[Maxim Kupfer]

(In reply to Matthew N. [:MattN] (at work week; PM if requests are blocking you) from comment #3)
> No, it shouldn't because addresses are autofilled separately from credit
> cards. e.g. see
> https://luke-chang.github.io/autofill-demo/multiple_sections/
> section_heuristics.html where each section gets their own autocomplete
> dialog.

Ah, I see. 

Question: How does formautofill figure out whether it will need to provide a dialog for an address or cc? If you could point me to the code, then that would be helpful as well.

Comment 5

[Matthew N. [:MattN]]

(In reply to Maxim Kupfer from comment #4)
> (In reply to Matthew N. [:MattN] (at work week; PM if requests are blocking
> you) from comment #3)
> > No, it shouldn't because addresses are autofilled separately from credit
> > cards. e.g. see
> > https://luke-chang.github.io/autofill-demo/multiple_sections/
> > section_heuristics.html where each section gets their own autocomplete
> > dialog.
> 
> Ah, I see. 
> 
> Question: How does formautofill figure out whether it will need to provide a
> dialog for an address or cc?

Btw. we call it an autocomplete popup, or more specifically in this case, the form autofill popup. 

> If you could point me to the code, then that would be helpful as well.

I don't know where that is off-hand and don't really have much time to explain it all. It shouldn't be needed for this bug btw.

Did you look at the existing work-in-progess (WIP) patch attached to this bug along with the TODOs in the commit message ( https://reviewboard.mozilla.org/r/211970/diff/1 )? It should give you a good start on what information is already available to the autocomplete popup.

Comment 6

[Maxim Kupfer]

>I don't know where that is off-hand and don't really have much time to explain it all. 
Ok I understand. 

>It shouldn't be needed for this bug btw.
Seems like hooking into this information would make the solution more modular as compared to the current patch, but I may be wrong as I'm still fresh to this project. 

>Did you look at the existing work-in-progess (WIP) patch attached to this bug along with the TODOs in the commit message ( https://reviewboard.mozilla.org/r/211970/diff/1 )? It should give you a good start on what information is already available to the autocomplete popup.

I did, and it didn't make sense to me. Mostly because I'm still figuring out how everything's pieced together, but also b/c it makes use of XML/XUL which I haven't done before. I've been meaning to go through the MDN docs (https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL) on that so this is a good chance to dig in.

Comment 7

[Maxim Kupfer]

No info needed, was just a follow up.