1497523 - Forms and Autofill is not focused by automatic scrolling when opened from the autocomplete footer

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[David Olah]

[Affected versions]: 
Nightly 64.0a1 (2018-10-09)

[Affected platforms]:
Platforms: Windows 10, Mac OS X, Ubuntu 16.04.

[Preconditions]:

Modify the following prefs via about:config:

- extensions.formautofill.available: on
- extensions.formautofill.creditCards.available: true

Make sure you have 1 or more credit cards saved.

[Steps to reproduce]:
1. Go to: https://luke-chang.github.io/autofill-demo/basic.html
2. Double click name or address field from the page
3. Click on "more options" button (preferences on Mac)

[Expected result]:
- User is redirected to about:preferences#privacy and Forms & Autofill is focused by autoscrolling

[Actual result]:
- User is redirected to about:preferences#privacy and the focus remains in top of the page (Forsm & Autofill is not focused by autoscrolling)

[Note]:
On 62 and 63, the Forms & Autofill section was olmost on the top of the page and no scroll was needed.

Comment 1

[Matthew N. [:MattN]]

I guess this is kinda a regression from moving the content blocking section up top. IIRC the problem before was that there wasn't a link to highlight both autofill sections. Since bug 1470184 there is now.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1497523 - Link to '#privacy-form-autofill' prefs instead of '#privacy' from autofill. r=jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0aa704cdd63
Link to '#privacy-form-autofill' prefs instead of '#privacy' from autofill. r=jaws

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e0aa704cdd63

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with 64.0a1 (2018-10-17) from taskcluster on Windows 10x64, MacOS 10.14 and Ubuntu 16.04.