1429054 - browser.sidebarAction.close() doesn't close sidebar from all windows

Status: RESOLVED DUPLICATE of bug 1427431

(WebExtensions :: Frontend, enhancement)

Description

[Rémy Hubscher (:natim)]

We implemented a toggle to open and close the sidebar if the toolbar button is clicked [0]

However if multiple windows are open, only the current window sidebar is closed turning the button functionality off.

[0] https://github.com/mozilla/notes/pull/515

Comment 1

[Rémy Hubscher (:natim)]

I tried this change: https://github.com/mozilla/notes/pull/576

But I get:  sidebarAction.close may only be called from a user input handler

Comment 2

[Andy McKay]

That's by design.

Comment 3

[Rémy Hubscher (:natim)]

Yes but own can I make a Toolbar button that toggle the sidebar? Can we have a toggle() sidebarAction?
How can I know that the current windows sidebar is closed or open?

Comment 4

[Andy McKay]

We are adding an isOpen (or similar API) in bug 1427431. 

Some of the discussion about opening or closing sidebars automatically has happened in other bugs such as bug 1343817 in a design-decision meeting. Overall we feel it's a user choice what sidebar that they have open per window and the costs of opening and closing sidebars is expensive and confusing. Unfortunately in the past this has been an area bad add-ons have caused users grief.

The ability to show an overlay is bug 1340930, what controls that might have we don't know yet but might be more appropriate.

Comment 6

[Rémy Hubscher (:natim)]

isOpen would work for us.