Policy: Remove Set As Desktop Background context menu option

VERIFIED FIXED in Firefox 60

Status

()

enhancement
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Felipe, Assigned: bytesized)

Tracking

Trunk
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Remove access to the "Set As Desktop Background" context menu option
(Assignee)

Updated

a year ago
Assignee: nobody → ksteuber
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8946415 - Flags: review?(gijskruitbosch+bugs)
Attachment #8946415 - Flags: review?(felipc)

Comment 3

a year ago
mozreview-review
Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

https://reviewboard.mozilla.org/r/216370/#review222186

This looks OK to me, assuming felipe thinks the policies stuff looks ok too.
Attachment #8946415 - Flags: review?(gijskruitbosch+bugs) → review+
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

https://reviewboard.mozilla.org/r/216370/#review222192

Yeah, policies parts are good too

::: browser/base/content/nsContextMenu.js:454
(Diff revision 2)
> -    if (AppConstants.HAVE_SHELL_SERVICE) {
> +    if (!Services.policies.isAllowed("set_desktop_background")) {
> +      haveSetDesktopBackground = false;
> +    } else if (AppConstants.HAVE_SHELL_SERVICE) {

Looks like this can be simplified as

> if (AppConstants.HAVE_SHELL_SERVICE &&
>     Services.policies.isAllowed("set_desktop_background"))
Attachment #8946415 - Flags: review?(felipc) → review+
Comment hidden (mozreview-request)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b44d2e0bc52a916bedbca0083cf66f1f2721948b -d 2afca7ece7b7: rebasing 444795:b44d2e0bc52a "Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option r=Felipe,Gijs" (tip)
merging browser/base/content/nsContextMenu.js
merging browser/components/enterprisepolicies/Policies.jsm
merging browser/components/enterprisepolicies/schemas/policies-schema.json
merging browser/components/enterprisepolicies/tests/browser/browser.ini
warning: conflicts while merging browser/components/enterprisepolicies/Policies.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/schemas/policies-schema.json! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/tests/browser/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 8

a year ago
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f622490e845d
Add enterprise policy to remove "Set As Desktop Background" context menu option r=Felipe,Gijs
https://hg.mozilla.org/mozilla-central/rev/f622490e845d
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
(Assignee)

Updated

a year ago
Blocks: 1434985
We tested this on Nightly[61] and beta[60]builds with ADM and JSON policy formats and it is verified as fixed.
Set As Desktop Background context menu option can be disabled by this policy.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.