Closed Bug 1429129 Opened 2 years ago Closed 2 years ago

Policy: Remove Set As Desktop Background context menu option

Categories

(Firefox :: Enterprise Policies, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 60
Tracking Status
firefox60 --- verified

People

(Reporter: Felipe, Assigned: bytesized)

References

Details

Attachments

(1 file)

Remove access to the "Set As Desktop Background" context menu option
Assignee: nobody → ksteuber
Attachment #8946415 - Flags: review?(gijskruitbosch+bugs)
Attachment #8946415 - Flags: review?(felipc)
Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

https://reviewboard.mozilla.org/r/216370/#review222186

This looks OK to me, assuming felipe thinks the policies stuff looks ok too.
Attachment #8946415 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

https://reviewboard.mozilla.org/r/216370/#review222192

Yeah, policies parts are good too

::: browser/base/content/nsContextMenu.js:454
(Diff revision 2)
> -    if (AppConstants.HAVE_SHELL_SERVICE) {
> +    if (!Services.policies.isAllowed("set_desktop_background")) {
> +      haveSetDesktopBackground = false;
> +    } else if (AppConstants.HAVE_SHELL_SERVICE) {

Looks like this can be simplified as

> if (AppConstants.HAVE_SHELL_SERVICE &&
>     Services.policies.isAllowed("set_desktop_background"))
Attachment #8946415 - Flags: review?(felipc) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b44d2e0bc52a916bedbca0083cf66f1f2721948b -d 2afca7ece7b7: rebasing 444795:b44d2e0bc52a "Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option r=Felipe,Gijs" (tip)
merging browser/base/content/nsContextMenu.js
merging browser/components/enterprisepolicies/Policies.jsm
merging browser/components/enterprisepolicies/schemas/policies-schema.json
merging browser/components/enterprisepolicies/tests/browser/browser.ini
warning: conflicts while merging browser/components/enterprisepolicies/Policies.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/schemas/policies-schema.json! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/tests/browser/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f622490e845d
Add enterprise policy to remove "Set As Desktop Background" context menu option r=Felipe,Gijs
https://hg.mozilla.org/mozilla-central/rev/f622490e845d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Blocks: 1434985
We tested this on Nightly[61] and beta[60]builds with ADM and JSON policy formats and it is verified as fixed.
Set As Desktop Background context menu option can be disabled by this policy.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.