1429129 - Policy: Remove Set As Desktop Background context menu option

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, enhancement, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

Remove access to the "Set As Desktop Background" context menu option

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

Review commit: https://reviewboard.mozilla.org/r/216370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216370/

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216370/diff/1-2/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

https://reviewboard.mozilla.org/r/216370/#review222186

This looks OK to me, assuming felipe thinks the policies stuff looks ok too.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

https://reviewboard.mozilla.org/r/216370/#review222192

Yeah, policies parts are good too

::: browser/base/content/nsContextMenu.js:454
(Diff revision 2)
> -    if (AppConstants.HAVE_SHELL_SERVICE) {
> +    if (!Services.policies.isAllowed("set_desktop_background")) {
> +      haveSetDesktopBackground = false;
> +    } else if (AppConstants.HAVE_SHELL_SERVICE) {

Looks like this can be simplified as

> if (AppConstants.HAVE_SHELL_SERVICE &&
>     Services.policies.isAllowed("set_desktop_background"))

Comment 5

[Robin Steuber (she/her) [:bytesized]]

Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216370/diff/2-3/

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b44d2e0bc52a916bedbca0083cf66f1f2721948b -d 2afca7ece7b7: rebasing 444795:b44d2e0bc52a "Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option r=Felipe,Gijs" (tip)
merging browser/base/content/nsContextMenu.js
merging browser/components/enterprisepolicies/Policies.jsm
merging browser/components/enterprisepolicies/schemas/policies-schema.json
merging browser/components/enterprisepolicies/tests/browser/browser.ini
warning: conflicts while merging browser/components/enterprisepolicies/Policies.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/schemas/policies-schema.json! (edit, then use 'hg resolve --mark')
warning: conflicts while merging browser/components/enterprisepolicies/tests/browser/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Robin Steuber (she/her) [:bytesized]]

Comment on attachment 8946415 [details]
Bug 1429129 - Add enterprise policy to remove "Set As Desktop Background" context menu option

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/216370/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f622490e845d
Add enterprise policy to remove "Set As Desktop Background" context menu option r=Felipe,Gijs

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f622490e845d

Comment 10

[Abe - QA (:Abe_LV)]

We tested this on Nightly[61] and beta[60]builds with ADM and JSON policy formats and it is verified as fixed.
Set As Desktop Background context menu option can be disabled by this policy.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760