1429144 - Policy: Don't remember search and form history

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

Policy: Don't remember search and form history (i.e., disable form autofill)

This is controlled by the browser.formfill.enable pref

Comment 1

[Matthew N. [:MattN]]

The pref that you mention is for form history, not Form Autofill. Should this policy disable both?

Comment 2

[:Felipe Gomes (needinfo for replies!)]

I've checked that locking the pref does the right thing in about:preferences: It changes the history dropdown to "custom settings", and grays out the form history checkbox.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1429144 - Policy: Don't remember search and form history.

Review commit: https://reviewboard.mozilla.org/r/218548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218548/

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8949150 [details]
Bug 1429144 - Policy: Don't remember search and form history.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218548/diff/1-2/

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8949150 [details]
Bug 1429144 - Policy: Don't remember search and form history.

https://reviewboard.mozilla.org/r/218548/#review224360

::: browser/components/enterprisepolicies/Policies.jsm:105
(Diff revision 2)
>      }
>    },
>  
> +  "DisableFormHistory": {
> +    onBeforeUIStartup(manager, param) {
> +      if (param == true) {

What is the point in comparing to true with == when you can just do `if (param) {`?

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8949150 [details]
Bug 1429144 - Policy: Don't remember search and form history.

https://reviewboard.mozilla.org/r/218548/#review224368

::: browser/components/enterprisepolicies/Policies.jsm:105
(Diff revision 2)
>      }
>    },
>  
> +  "DisableFormHistory": {
> +    onBeforeUIStartup(manager, param) {
> +      if (param == true) {

not really much point.. I guess it helps make it easier to understand what's the type of this variable here, since "param" is a generic name, and can have other types for other policies.

But it's not common on our codebase for sure, so I wonder if I should drop that.. Almost all policies have used this style

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ee280615e45
Policy: Don't remember search and form history. r=MattN

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5ee280615e45

Comment 9

[Abe - QA (:Abe_LV)]

In this bug, we tested the "form history" policy only.  As we discussed with the developer, Felipe, the current work does not include 'do not remember search'. 

It is verified manually as fixed using JSON file. 
The bug will also be retested with ADMX files when it is ready for testing.

Test steps and runs are available here: https://testrail.stage.mozaws.net/index.php?/plans/view/7734

Comment 10

[Abe - QA (:Abe_LV)]

We retested this on beta builds[FX60] with ADM and JSON policy formats and it is verified as fixed.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760