1429161 - Disable Forget Button

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

Disable the Forget (Panic) button

privacy.panicButton.enabled

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

Review commit: https://reviewboard.mozilla.org/r/233152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233152/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

https://reviewboard.mozilla.org/r/233152/#review238670

::: browser/components/enterprisepolicies/tests/browser/disable_forget_button/browser_policy_disable_forgetbutton.js:7
(Diff revision 1)
> + * http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +"use strict";
> +
> +add_task(async function test_policy_disable_forget_button() {
> +  let widget =  CustomizableUI.getWidget("panic-button");

nit, only one space after the = sign :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b69de0df02ce
Policy: Disable Forget Button. r=jaws

Comment 4

[:Felipe Gomes (needinfo for replies!)]

[Tracking Requested - why for this release]:
Enterprise Policies

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/b69de0df02ce

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233152/diff/1-2/

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

https://reviewboard.mozilla.org/r/233152/#review239408

rs=me

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7495760c7501
Policy follow-up: hide instead of disabling the Forget button. r=jaws

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise Policies
[User impact if declined]: Policy to hide the Forget button
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: QA is checking it
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: limited to this policy being used, simple pref toggle
[String changes made/needed]: none

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7495760c7501

Comment 11

[Abe - QA (:Abe_LV)]

We tested this on the latest nightly with JSON policy format and it is verified as fixed.
With this policy, forget button can be hidden.

We will retest this with adm policy format when ready.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

enterprise policy, approved for 60.0b11

Comment 13

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe973bfe84fed734c21bad646ba0a4cf88ed78f8

Comment 14

[Abe - QA (:Abe_LV)]

We retested this on beta builds[FX60] with ADM and JSON policy formats and it is verified as fixed.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.