Status

()

defect
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

Trunk
Firefox 61
Points:
---

Firefox Tracking Flags

(firefox59 unaffected, firefox60+ verified, firefox61 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Disable the Forget (Panic) button

privacy.panicButton.enabled
(Assignee)

Updated

a year ago
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

https://reviewboard.mozilla.org/r/233152/#review238670

::: browser/components/enterprisepolicies/tests/browser/disable_forget_button/browser_policy_disable_forgetbutton.js:7
(Diff revision 1)
> + * http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +"use strict";
> +
> +add_task(async function test_policy_disable_forget_button() {
> +  let widget =  CustomizableUI.getWidget("panic-button");

nit, only one space after the = sign :)
Attachment #8964419 - Flags: review?(jaws) → review+
(Assignee)

Comment 4

a year ago
[Tracking Requested - why for this release]:
Enterprise Policies

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b69de0df02ce
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment hidden (mozreview-request)
Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

https://reviewboard.mozilla.org/r/233152/#review239408

rs=me

Comment 8

a year ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7495760c7501
Policy follow-up: hide instead of disabling the Forget button. r=jaws
(Assignee)

Comment 9

a year ago
Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise Policies
[User impact if declined]: Policy to hide the Forget button
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: QA is checking it
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: limited to this policy being used, simple pref toggle
[String changes made/needed]: none
Attachment #8964419 - Flags: approval-mozilla-beta?
We tested this on the latest nightly with JSON policy format and it is verified as fixed.
With this policy, forget button can be hidden.

We will retest this with adm policy format when ready.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760
Comment on attachment 8964419 [details]
Bug 1429161. Policy follow-up: hide instead of disabling the Forget button.

enterprise policy, approved for 60.0b11
Attachment #8964419 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
We retested this on beta builds[FX60] with ADM and JSON policy formats and it is verified as fixed.

Test cases and runs are here- https://testrail.stage.mozaws.net/index.php?/plans/view/8760
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.