1429213 - Implement the "unknown"/timeout screen for when the merchant rejects the payment and doesn't request retrying

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

After sending the PaymentResponse to the merchant via the DOM code, the merchant should respond to indicate if the payment was accepted or rejected. If the merchant calls `PaymentResponse.complete` with the argument "unknown" or `complete` isn't called within a reasonable time, a generic final message should be shown before the dialog closes.

> "unknown"
>    The developer did not indicate success or failure and the user agent SHOULD NOT display UI indicating success or failure.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Until we have bug 1441683 fixed, I'll just implement this bug showing the "unknown" state on the button. We can use bug 1441683 or a follow-up to implement the timeout.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

Review commit: https://reviewboard.mozilla.org/r/224060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224060/

Comment 3

[Matthew N. [:MattN]]

Why do we need bug 1441683 to handle the timeout case since we know when complete is called?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, we could do it here. I had been thinking of waiting until we got the completeStatus since merchants can't effectively use the completeStatus argument yet anyways, but .complete() and .complete("unknown") act the same so I can do it here.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224060/diff/1-2/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224060/diff/2-3/

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

https://reviewboard.mozilla.org/r/224060/#review230576

Can you split the timeout stuff to a separate commit? It's easier to review and matches the commit message. r+ on revision 1 that just had unknown. It should be easy to recreate from the revision 1 commit.

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

https://reviewboard.mozilla.org/r/224060/#review230584

::: toolkit/components/payments/paymentUIService.js:70
(Diff revision 3)
>    completePayment(requestId) {
>      this.log.debug("completePayment:", requestId);
> +    let dialog = this.findDialog(requestId);
> +    if (dialog && dialog.unknownTimeoutId) {
> +      dialog.clearTimeout(dialog.unknownTimeoutId);
> +    }
>      let closed = this.closeDialog(requestId);

Please add a test for this behaviour. It's easy to directly call this method in a m-bc test for now to simulate the DOM calling it.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1429213 - Implement the 'unknown' screen for when the merchant rejects the payment.

Review commit: https://reviewboard.mozilla.org/r/224790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224790/

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224060/diff/3-4/

Comment 11

[Matthew N. [:MattN]]

Comment on attachment 8955704 [details]
Bug 1429213 - Implement the 'unknown' screen for when the merchant rejects the payment.

https://reviewboard.mozilla.org/r/224790/#review231414

Comment 12

[Matthew N. [:MattN]]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

https://reviewboard.mozilla.org/r/224060/#review231418

Thanks

::: toolkit/components/payments/test/browser/browser.ini:5
(Diff revision 4)
>  [DEFAULT]
>  head = head.js
>  prefs =
>    dom.payments.request.enabled=true
> +  dom.payments.unknownTimeoutMS=0

Please file a follow-up to test the timeout duration.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8955704 [details]
Bug 1429213 - Implement the 'unknown' screen for when the merchant rejects the payment.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224790/diff/1-2/

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224060/diff/4-5/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/752ad36df388
Implement the 'unknown' screen for when the merchant rejects the payment. r=MattN
https://hg.mozilla.org/integration/autoland/rev/3f419c7dcf2a
Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called. r=MattN

Comment 16

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954895 [details]
Bug 1429213 - Time out the payment dialog after the user clicks 'Pay', closing the dialog if response.complete() is not called.

https://reviewboard.mozilla.org/r/224060/#review231418

> Please file a follow-up to test the timeout duration.

Filed bug 1443885.

Comment 17

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61ac0108bef6
Backed out 2 changesets for mochitest browser chrome failures at browser_show_dialog.js on a CLOSED TREE

Comment 18

[Cosmin Sabou [:CosminS]]

Backed out for mochitest browser chrome failures at browser_show_dialog.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3f419c7dcf2a8f07fd057953725267f8e901ccdf&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=166559091

Failures log: https://treeherder.mozilla.org/logviewer.html#?job_id=166559091&repo=autoland&lineNumber=15205

Backout link: https://hg.mozilla.org/integration/autoland/rev/61ac0108bef63654c2ab2d75161e18a985f7adfd

Comment 19

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8955704 [details]
Bug 1429213 - Implement the 'unknown' screen for when the merchant rejects the payment.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224790/diff/2-3/

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cf36c1b89d5
Implement the 'unknown' screen for when the merchant rejects the payment. r=MattN

Comment 21

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/4cf36c1b89d5