1429207 - Implement the "failure" screen for when the merchant rejects the payment and doesn't request retrying

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement, P1)

Description

[Matthew N. [:MattN]]

After sending the PaymentResponse to the merchant via the DOM code, the merchant responds to indicate if the payment was accepted or rejected. If the front-end code receives `nsIPaymentActionResponse.PAYMENT_REJECTED` (retrying isn't supported) then failure UI should appear.

Retry (error recovery) support is being discussed in https://github.com/w3c/payment-request/issues/647

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment.

Review commit: https://reviewboard.mozilla.org/r/223724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223724/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8954636 [details]
Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment.

https://reviewboard.mozilla.org/r/223724/#review229768

Thanks

::: toolkit/components/payments/test/mochitest/test_payment_dialog.html:126
(Diff revision 1)
> -  await el1.requestStore.setState({completionState: "processing"});
> -  await asyncElementRendered();
> +  for (let [completionState, label] of completionStates) {
> +    await el1.requestStore.setState({completionState});
> -  is(payButton.textContent, "Processing", "Check processing label");
> -  ok(!payButton.disabled, "Button is still enabled");
> -  await el1.requestStore.setState({completionState: "success"});
> -  await asyncElementRendered();
> +    await asyncElementRendered();
> -  is(payButton.textContent, "Done", "Check success label");
> +    is(payButton.textContent, label, "Check payButton label");
> -  ok(!payButton.disabled, "Button is still enabled");
> +    ok(!payButton.disabled, "Button is still enabled");
> +  }

This also works (re: my review of success).

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8954636 [details]
Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment.

https://reviewboard.mozilla.org/r/223724/#review229770

Oops

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954636 [details]
Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223724/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1b30d54da0b
Implement the 'failure' screen for when the merchant rejects the payment. r=MattN

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e1b30d54da0b