Implement the "failure" screen for when the merchant rejects the payment and doesn't request retrying

RESOLVED FIXED in Firefox 60

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: MattN, Assigned: jaws)

Tracking

Trunk
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [webpayments], )

Attachments

(1 attachment)

After sending the PaymentResponse to the merchant via the DOM code, the merchant responds to indicate if the payment was accepted or rejected. If the front-end code receives `nsIPaymentActionResponse.PAYMENT_REJECTED` (retrying isn't supported) then failure UI should appear.

Retry (error recovery) support is being discussed in https://github.com/w3c/payment-request/issues/647
Priority: P3 → P1
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8954636 [details]
Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment.

https://reviewboard.mozilla.org/r/223724/#review229768

Thanks

::: toolkit/components/payments/test/mochitest/test_payment_dialog.html:126
(Diff revision 1)
> -  await el1.requestStore.setState({completionState: "processing"});
> -  await asyncElementRendered();
> +  for (let [completionState, label] of completionStates) {
> +    await el1.requestStore.setState({completionState});
> -  is(payButton.textContent, "Processing", "Check processing label");
> -  ok(!payButton.disabled, "Button is still enabled");
> -  await el1.requestStore.setState({completionState: "success"});
> -  await asyncElementRendered();
> +    await asyncElementRendered();
> -  is(payButton.textContent, "Done", "Check success label");
> +    is(payButton.textContent, label, "Check payButton label");
> -  ok(!payButton.disabled, "Button is still enabled");
> +    ok(!payButton.disabled, "Button is still enabled");
> +  }

This also works (re: my review of success).
Attachment #8954636 - Flags: review?(MattN+bmo) → review-
Comment on attachment 8954636 [details]
Bug 1429207 - Implement the 'failure' screen for when the merchant rejects the payment.

https://reviewboard.mozilla.org/r/223724/#review229770

Oops
Attachment #8954636 - Flags: review- → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1b30d54da0b
Implement the 'failure' screen for when the merchant rejects the payment. r=MattN

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e1b30d54da0b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Whiteboard: [webpayments]
Component: WebPayments UI → WebPayments UI
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
You need to log in before you can comment on or make changes to this bug.