Closed Bug 1429238 Opened 6 years ago Closed 6 years ago

Update Debugger Frontend v7.0

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

7.patch
141.62 KB, patch
jdescottes
: review+
Details | Diff | Splinter Review
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Priority: -- → P3
Attached patch 7.patch — — Splinter Review 

        Attachment #8941311 -
        Flags: review?(jdescottes)

    
    

    
  
Comment on attachment 8941311 [details] [diff] [review]
7.patch

Review of attachment 8941311 [details] [diff] [review]:
-----------------------------------------------------------------

Try looks good. We should agree and settle on a try syntax though, looks like now we do all platforms + all tests + rebuild 2?
The README is missing information here (maybe a misunderstanding after our conversation yesterday).

I'll update the readme and push to avoid losing time here, but let's discuss enabling the workers feature today.

::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> +Taken from upstream commit: fb10a431822a1a1eb22e02613cb09cf12a10e67a

Information missing? Version number + at least one link, as discussed yesterday.

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +124,5 @@
>  [browser_dbg-tabs-pretty-print.js]
>  [browser_dbg-toggling-tools.js]
>  skip-if = true # Bug 1414124
>  [browser_dbg-wasm-sourcemaps.js]
> +skip-if = true

If we're not using Bug 1415300 to investigate those failures, can you close it and remove all references to it from this file?

::: devtools/client/preferences/debugger.js
@@ +27,5 @@
>  pref("devtools.debugger.ui.variables-searchbox-visible", false);
>  pref("devtools.debugger.ui.framework-grouping-on", true);
>  pref("devtools.debugger.call-stack-visible", true);
>  pref("devtools.debugger.scopes-visible", true);
> +pref("devtools.debugger.workers-visible", true);

I quickly tested the new workers pane. Feature seems to work fine, but I'm a bit worried with preffing this on right before the end of 59. The location of the panel seems very WIP/bizarre to me: below the command bar, above the watch expressions? Seems like something which should be with the sources?

I guess we could always uplift a pref change to disable it in case the feedback is not as good as expected?

        Attachment #8941311 -
        Flags: review?(jdescottes) → review+

    
    

    
  
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bcb9a936d33
Update Debugger Frontend v7.0. r=jdescottes

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4bcb9a936d33
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox59:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59

    
  
Depends on: 1433681

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.