Closed Bug 1429260 Opened 2 years ago Closed Last year

Handle request changes with updateWith - verify that state stays consistent

Categories

(Firefox :: WebPayments UI, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: MattN, Assigned: sfoster)

References

(Depends on 2 open bugs)

Details

(Whiteboard: [webpayments])

Attachments

(2 files)

This bug tracks auditing the dialog behaviour to ensure that dialog state remains consistent when the Payment Request is changed.

Bug 1429190 is one example where there could be a problem but there are possibly others.
Priority: P3 → P2
Whiteboard: [webpayments]
Product: Toolkit → Firefox
This should entail reviewing existing test coverage and adding any necessary tests to ensure we have implemented updateWith handling, and that it doesn't regress.
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8980473 [details]
Bug 1429260 - Refactor PTU.Details data to only include the expected properties.

https://reviewboard.mozilla.org/r/246638/#review253044
Attachment #8980473 - Flags: review?(jaws) → review+
Comment on attachment 8980473 [details]
Bug 1429260 - Refactor PTU.Details data to only include the expected properties.

https://reviewboard.mozilla.org/r/246638/#review253046

This will need to be rebased on top of the shippingAddressErrors patch that landed in bug 1427959.
Comment on attachment 8980474 [details]
Bug 1429260 - Add tests to verify handling of payment detail properties it is possible to updateWith.

https://reviewboard.mozilla.org/r/246640/#review253112

::: browser/components/payments/test/browser/browser_change_shipping.js:78
(Diff revision 1)
> +         "\u20AC2.50",
> +         "Check updated total currency amount");
> +
> +      let btn = content.document.querySelector("#view-all");
> +      btn.click();
> +      await content.Promise.resolve();

This should use
```
      await PTU.DialogContentUtils.waitForState(content, (state) => {
        return state.orderDetailsShowing;
      }, "Order details show be showing now");
```
Attachment #8980474 - Flags: review?(jaws) → review+
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42fb8fd8d64b
Refactor PTU.Details data to only include the expected properties. r=jaws
https://hg.mozilla.org/integration/autoland/rev/d7379d70b963
Add tests to verify handling of payment detail properties it is possible to updateWith. r=jaws
https://hg.mozilla.org/mozilla-central/rev/42fb8fd8d64b
https://hg.mozilla.org/mozilla-central/rev/d7379d70b963
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.