Closed Bug 1429352 Opened 2 years ago Closed 2 years ago

progressmeter.css cleanup

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

- remove obsolete .progressmeter-statusbar rule
- replace Windows 98 style shadow with a flat one (this is only used on platforms where we don't implement -moz-appearance: progressbar -- not sure that this actually the case anywhere)
- minor formatting fixes
Priority: -- → P3
Comment on attachment 8941379 [details]
Bug 1429352 - progressmeter.css cleanup.

https://reviewboard.mozilla.org/r/211694/#review217464

LGTM!

::: toolkit/themes/windows/global/progressmeter.css
(Diff revision 1)
> -  border: 2px solid;
> +  border: 1px solid ThreeDShadow;
> -  -moz-border-top-colors: ThreeDShadow -moz-Dialog;
> -  -moz-border-right-colors: ThreeDHighlight -moz-Dialog;
> -  -moz-border-bottom-colors: ThreeDHighlight -moz-Dialog;
> -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> -  background-color: -moz-Dialog;

As mentioned on IRC, it might be better to keep that background-color. Up to you :)
Attachment #8941379 - Flags: review?(ntim.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c0f34f8aaef3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Blocks: 1429723
You need to log in before you can comment on or make changes to this bug.