1429352 - progressmeter.css cleanup

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[Dão Gottwald [:dao]]

- remove obsolete .progressmeter-statusbar rule
- replace Windows 98 style shadow with a flat one (this is only used on platforms where we don't implement -moz-appearance: progressbar -- not sure that this actually the case anywhere)
- minor formatting fixes

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1429352 - progressmeter.css cleanup.

Review commit: https://reviewboard.mozilla.org/r/211694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211694/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8941379 [details]
Bug 1429352 - progressmeter.css cleanup.

https://reviewboard.mozilla.org/r/211694/#review217464

LGTM!

::: toolkit/themes/windows/global/progressmeter.css
(Diff revision 1)
> -  border: 2px solid;
> +  border: 1px solid ThreeDShadow;
> -  -moz-border-top-colors: ThreeDShadow -moz-Dialog;
> -  -moz-border-right-colors: ThreeDHighlight -moz-Dialog;
> -  -moz-border-bottom-colors: ThreeDHighlight -moz-Dialog;
> -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> -  background-color: -moz-Dialog;

As mentioned on IRC, it might be better to keep that background-color. Up to you :)

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8941379 [details]
Bug 1429352 - progressmeter.css cleanup.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211694/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0f34f8aaef3
progressmeter.css cleanup. r=ntim

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c0f34f8aaef3