1429723 - Drop support for -moz-border-*-colors

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Dão Gottwald [:dao]]

Bug 1417200 made -moz-border-*-colors chrome-only. We've now removed most uses from chrome stylesheets, so before long there will be no point in maintaining support for -moz-border-*-colors.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Happy to take it, just ni? me when all uses are gone :)

Comment 2

[Tim Nguyen :ntim]

https://dxr.mozilla.org/mozilla-central/search?q=moz-border-+-path%3Athird_party+-path%3Amobile%2Fandroid%2Ftest+-path%3Aobj-&redirect=false

Comment 3

[Dão Gottwald [:dao]]

Better query: https://dxr.mozilla.org/mozilla-central/search?q=%22-colors%3A%22+-path%3Athird_party+-path%3Amobile%2Fandroid%2Ftest+-path%3Aobj-&redirect=true

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Given this is moving fast I just wrote a patch. Hopefully it doesn't bitrot :)

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1429723: Remove -moz-border-*-colors.

To land as soon as the existing uses are gone from the tree.

Review commit: https://reviewboard.mozilla.org/r/212800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212800/

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1429723: Graphics cleanup.

Review commit: https://reviewboard.mozilla.org/r/212802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212802/

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1429723: Remove static analysis special-case that is no longer relevant.

Review commit: https://reviewboard.mozilla.org/r/212804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212804/

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review218442

I can see that we may want to remove it as soon as possible... but I would prefer we wait until the beginning of 60.

Normally I'd want to wait until bug 1417200 reaches release, so that we at least can confirm this doesn't really cause issue badly. But 60 would become the next ESR, and maintaining the code removed here in an ESR may be an extra burden... So let's just wait until then, and we would have at least some more confidence from bug 1417200 being in beta.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8942553 [details]
Bug 1429723: Graphics cleanup.

https://reviewboard.mozilla.org/r/212802/#review218576

Beautiful

Comment 10

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8942554 [details]
Bug 1429723: Remove static analysis special-case that is no longer relevant.

https://reviewboard.mozilla.org/r/212804/#review218910

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

58 already has a release branch, 59 will branch to beta ASAP, so I'd like to get this reviewed.

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review219934

OK

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3017b55cf82d
Remove -moz-border-*-colors. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/750cbdd7eb8c
Graphics cleanup. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a3642d94dc8b
Remove static analysis special-case that is no longer relevant. r=sfink

Comment 14

[Dão Gottwald [:dao]]

dev-doc-needed: remove https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-border-bottom-colors and friends

Comment 15

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3017b55cf82d
https://hg.mozilla.org/mozilla-central/rev/750cbdd7eb8c
https://hg.mozilla.org/mozilla-central/rev/a3642d94dc8b

Comment 16

[Chris Mills [:cmills]]

I've sent in a PR to update the browser compat data for these properties:

https://github.com/mdn/browser-compat-data/pull/1200