Drop support for -moz-border-*-colors

NEW
Assigned to

Status

()

Core
CSS Parsing and Computation
11 days ago
3 days ago

People

(Reporter: dao, Assigned: emilio)

Tracking

(Depends on: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

11 days ago
Bug 1417200 made -moz-border-*-colors chrome-only. We've now removed most uses from chrome stylesheets, so before long there will be no point in maintaining support for -moz-border-*-colors.
(Assignee)

Comment 1

11 days ago
Happy to take it, just ni? me when all uses are gone :)
(Reporter)

Updated

9 days ago
Depends on: 1357832
(Reporter)

Updated

9 days ago
Depends on: 1430371
(Reporter)

Updated

9 days ago
Depends on: 1430372
(Reporter)

Updated

8 days ago
Depends on: 1430457
(Assignee)

Updated

7 days ago
Depends on: 1430512
(Assignee)

Comment 4

7 days ago
Given this is moving fast I just wrote a patch. Hopefully it doesn't bitrot :)
Assignee: nobody → emilio
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review218442

I can see that we may want to remove it as soon as possible... but I would prefer we wait until the beginning of 60.

Normally I'd want to wait until bug 1417200 reaches release, so that we at least can confirm this doesn't really cause issue badly. But 60 would become the next ESR, and maintaining the code removed here in an ESR may be an extra burden... So let's just wait until then, and we would have at least some more confidence from bug 1417200 being in beta.
Attachment #8942552 - Flags: review?(xidorn+moz)

Comment 9

7 days ago
mozreview-review
Comment on attachment 8942553 [details]
Bug 1429723: Graphics cleanup.

https://reviewboard.mozilla.org/r/212802/#review218576

Beautiful
Attachment #8942553 - Flags: review?(jmuizelaar) → review+
(Reporter)

Updated

7 days ago
Depends on: 1430647

Comment 10

6 days ago
mozreview-review
Comment on attachment 8942554 [details]
Bug 1429723: Remove static analysis special-case that is no longer relevant.

https://reviewboard.mozilla.org/r/212804/#review218910
Attachment #8942554 - Flags: review?(sphink) → review+
(Reporter)

Updated

6 days ago
Depends on: 1430871
(Assignee)

Comment 11

4 days ago
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

58 already has a release branch, 59 will branch to beta ASAP, so I'd like to get this reviewed.
Attachment #8942552 - Flags: review?(xidorn+moz)
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review219934

OK
Attachment #8942552 - Flags: review?(xidorn+moz) → review+
You need to log in before you can comment on or make changes to this bug.