Drop support for -moz-border-*-colors

RESOLVED FIXED in Firefox 60

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: emilio)

Tracking

({dev-doc-complete})

unspecified
mozilla60
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

a year ago
Bug 1417200 made -moz-border-*-colors chrome-only. We've now removed most uses from chrome stylesheets, so before long there will be no point in maintaining support for -moz-border-*-colors.
(Assignee)

Comment 1

a year ago
Happy to take it, just ni? me when all uses are gone :)
(Reporter)

Updated

a year ago
Depends on: 1357832
(Reporter)

Updated

a year ago
Depends on: 1430371
(Reporter)

Updated

a year ago
Depends on: 1430372
(Reporter)

Updated

a year ago
Depends on: 1430457
(Assignee)

Updated

a year ago
Depends on: 1430512
(Assignee)

Comment 4

a year ago
Given this is moving fast I just wrote a patch. Hopefully it doesn't bitrot :)
Assignee: nobody → emilio
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

a year ago
mozreview-review
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review218442

I can see that we may want to remove it as soon as possible... but I would prefer we wait until the beginning of 60.

Normally I'd want to wait until bug 1417200 reaches release, so that we at least can confirm this doesn't really cause issue badly. But 60 would become the next ESR, and maintaining the code removed here in an ESR may be an extra burden... So let's just wait until then, and we would have at least some more confidence from bug 1417200 being in beta.
Attachment #8942552 - Flags: review?(xidorn+moz)

Comment 9

a year ago
mozreview-review
Comment on attachment 8942553 [details]
Bug 1429723: Graphics cleanup.

https://reviewboard.mozilla.org/r/212802/#review218576

Beautiful
Attachment #8942553 - Flags: review?(jmuizelaar) → review+
(Reporter)

Updated

a year ago
Depends on: 1430647

Comment 10

a year ago
mozreview-review
Comment on attachment 8942554 [details]
Bug 1429723: Remove static analysis special-case that is no longer relevant.

https://reviewboard.mozilla.org/r/212804/#review218910
Attachment #8942554 - Flags: review?(sphink) → review+
(Reporter)

Updated

a year ago
Depends on: 1430871
(Assignee)

Comment 11

a year ago
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

58 already has a release branch, 59 will branch to beta ASAP, so I'd like to get this reviewed.
Attachment #8942552 - Flags: review?(xidorn+moz)

Comment 12

a year ago
mozreview-review
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review219934

OK
Attachment #8942552 - Flags: review?(xidorn+moz) → review+

Comment 13

a year ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3017b55cf82d
Remove -moz-border-*-colors. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/750cbdd7eb8c
Graphics cleanup. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a3642d94dc8b
Remove static analysis special-case that is no longer relevant. r=sfink
(Reporter)

Comment 14

a year ago
dev-doc-needed: remove https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-border-bottom-colors and friends
Keywords: dev-doc-needed

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3017b55cf82d
https://hg.mozilla.org/mozilla-central/rev/750cbdd7eb8c
https://hg.mozilla.org/mozilla-central/rev/a3642d94dc8b
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
I've sent in a PR to update the browser compat data for these properties:

https://github.com/mdn/browser-compat-data/pull/1200
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.