Closed Bug 1429723 Opened 6 years ago Closed 6 years ago

Drop support for -moz-border-*-colors

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: dao, Assigned: emilio)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Bug 1417200 made -moz-border-*-colors chrome-only. We've now removed most uses from chrome stylesheets, so before long there will be no point in maintaining support for -moz-border-*-colors.
Happy to take it, just ni? me when all uses are gone :)
Depends on: 1357832
Depends on: 1430371
Depends on: 1430372
Depends on: 1430457
Depends on: 1430512
Given this is moving fast I just wrote a patch. Hopefully it doesn't bitrot :)
Assignee: nobody → emilio
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review218442

I can see that we may want to remove it as soon as possible... but I would prefer we wait until the beginning of 60.

Normally I'd want to wait until bug 1417200 reaches release, so that we at least can confirm this doesn't really cause issue badly. But 60 would become the next ESR, and maintaining the code removed here in an ESR may be an extra burden... So let's just wait until then, and we would have at least some more confidence from bug 1417200 being in beta.
Attachment #8942552 - Flags: review?(xidorn+moz)
Comment on attachment 8942553 [details]
Bug 1429723: Graphics cleanup.

https://reviewboard.mozilla.org/r/212802/#review218576

Beautiful
Attachment #8942553 - Flags: review?(jmuizelaar) → review+
Depends on: 1430647
Comment on attachment 8942554 [details]
Bug 1429723: Remove static analysis special-case that is no longer relevant.

https://reviewboard.mozilla.org/r/212804/#review218910
Attachment #8942554 - Flags: review?(sphink) → review+
Depends on: 1430871
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

58 already has a release branch, 59 will branch to beta ASAP, so I'd like to get this reviewed.
Attachment #8942552 - Flags: review?(xidorn+moz)
Comment on attachment 8942552 [details]
Bug 1429723: Remove -moz-border-*-colors.

https://reviewboard.mozilla.org/r/212800/#review219934

OK
Attachment #8942552 - Flags: review?(xidorn+moz) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3017b55cf82d
Remove -moz-border-*-colors. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/750cbdd7eb8c
Graphics cleanup. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a3642d94dc8b
Remove static analysis special-case that is no longer relevant. r=sfink
I've sent in a PR to update the browser compat data for these properties:

https://github.com/mdn/browser-compat-data/pull/1200
You need to log in before you can comment on or make changes to this bug.