1429594 - SVG transform animation visual corruption

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[aostai]

Attachment: glitch example.html

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20180103231032

Steps to reproduce:

SVG group has a mask applied to it with a circle nested within. Apply a rotation animation via greensock, produces a transform:matrix3d. On play back Firefox glitches out on the animation.

I can also reproduce this by applying a transform: rotation(); in inspector and incrementing the degree of the circle's rotation. Once the number is no longer changing the glitch will go away.



Actual results:

In Firefox 57 it glitches out, see attached HTML for a demo file.
Recording: https://www.youtube.com/watch?v=dhizzlgHUKE



Expected results:

Firefox 55 and older produced proper animations identical to Chrome and IE11. Beginning with FF56, I noticed this happening intermittently on my work computer but no one else seemed to experience it. Now in FF57 this happens on all FF installs I have checked across a variety of hardware (AMD/Intel CPU’s, and Intel and Nvidia GPU’s). Bug persists in Dev build and nightly of Firefox on my work computer.

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have tested this issue on 3 different systems and managed to reproduce it on two of them, using the attached test case. Reproducible on latest Firefox 57.0.4 release and latest Nightly (59.0a1) build on Windows 7 x64, windows 8.1 x64 and Windows 10 x64.
I haven't managed to reproduce the issue is not reproducible on Mac or Linux.

I am not sure why the issue is not reproducible on all the 3 systems. I have tested on each system and OS with a new Firefox profile. Probably the issue is related to video drivers or video cards. Attaching the "about:support" page for the two different systems:
- Windows 10 x64 with Nightly 59.0a1 where the issue is reproducible: https://goo.gl/zesMBr
- Windows 10 x64 with Nightly 59.0a1 where the issue is not reproducible: https://goo.gl/cu2WY4

The issue is not reproducible on Firefox 50 release. Considering this I have performed a regression using mozregression tools. here are the results:
Last good revision: 6b534147049e9a4afaa3320712d824dc9563ac67
First bad revision: 7fb451a4d22c87e7de74be4c169c85601bdb938e
Pushlog: https://goo.gl/tL3LhS
It seems that bug 1359527 introduced this issue.

Since the Mason Chang's account is disabled, Jeff can you please take a look at this issue?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This was apparently fixed by bug 1438631 according to mozregression. Not sure if that was an expected result, but the testcase definitely no longer reproduces for me with Beta60 or current Nightly with a clean profile (no webrender).

Comment 3

[Jeff Muizelaar [:jrmuizel]]

It's ok that bug 1438631 fixed this. bug 1438631 was a generic "do better" fix not specific to webrender.