1429603 - Cleanup mozharness build configs.

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Tom Prince [:tomprince]]

There is a bunch of unused code and config options in the build mozharness configs, they should be cleaned up.

Comment 1

[Tom Prince [:tomprince]]

Jordan, I'd ask for review for these, but you do not appear to have a phabricator account.

Comment 2

[Tom Prince [:tomprince]]

Update with new user.

Comment 3

[Phabricator Automation]

Comment on attachment 8943711 [details]
Bug 1429603: Don't specify balrog servers for builds; r?jlund

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D415#10004

Comment 4

[Phabricator Automation]

Comment on attachment 8941639 [details]
Bug 1429603: Get rid of clone-tools.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D373#10011

Comment 5

[Phabricator Automation]

Comment on attachment 8941637 [details]
Bug 1429603: Remove some usused imports in mozharness configs.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D371#10015

Comment 6

[Phabricator Automation]

Comment on attachment 8941636 [details]
Bug 1429603: Remove some unused tooltool mozharness config settings.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D370#10017

Comment 7

[Phabricator Automation]

Comment on attachment 8941635 [details]
Bug 1429603: Remove mock configuration from build mozharness configs and code.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D369#10020

Comment 8

[Phabricator Automation]

Comment on attachment 8941634 [details]
Bug 1429603: Remove CCACHE environment variables.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D368#10022

Comment 9

[Phabricator Automation]

Comment on attachment 8941633 [details]
Bug 1429603: Remove always false `enable_talos_sendchange`.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D367#10025

Comment 10

[Phabricator Automation]

Comment on attachment 8941632 [details]
Bug 1429603: Remove unused releng windows and native macOS mozharness configs.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D366#10028

Comment 11

[Phabricator Automation]

Comment on attachment 8941638 [details]
Bug 1429603: Get rid of support for builds using buildbot-bridge.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D372#10055

Comment 12

[Phabricator Automation]

Comment on attachment 8941640 [details]
Bug 1429603: Get rid of some unused commands.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D374#10057

Comment 13

[Phabricator Automation]

Comment on attachment 8943710 [details]
Bug 1429603: Only run build and check as part of mingw32 build.

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D414#10060

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ec9afb3329ab
Get rid of unused balrog configuration in builds; r=me

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9882ff3c7d4
Remove unused releng windows and native macOS mozharness configs; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b2cf60361b5
Remove always false `enable_talos_sendchange`; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d82d82fa62d
Remove CCACHE environment variables; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/adf77c633d8f
Remove mock configuration from build mozharness configs and code; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/dab1ff1d2a10
Remove some unused tooltool mozharness config settings; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/63d8f5126c42
Remove some usused imports in mozharness configs; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/9085ab97d538
Get rid of support for builds using buildbot-bridge; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b3d09ace2c
Get rid of clone-tools; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/832e46690f50
Only run build and check as part of mingw32 build; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/605111b6f51f
Get rid of some unused mozharness steps; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/83662b9338da
Don't specify balrog servers for builds; r=jlund

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f9882ff3c7d4
https://hg.mozilla.org/mozilla-central/rev/2b2cf60361b5
https://hg.mozilla.org/mozilla-central/rev/8d82d82fa62d
https://hg.mozilla.org/mozilla-central/rev/adf77c633d8f
https://hg.mozilla.org/mozilla-central/rev/dab1ff1d2a10
https://hg.mozilla.org/mozilla-central/rev/63d8f5126c42
https://hg.mozilla.org/mozilla-central/rev/9085ab97d538
https://hg.mozilla.org/mozilla-central/rev/f6b3d09ace2c
https://hg.mozilla.org/mozilla-central/rev/832e46690f50
https://hg.mozilla.org/mozilla-central/rev/605111b6f51f
https://hg.mozilla.org/mozilla-central/rev/83662b9338da

Comment 17

[Phabricator Automation]

Attachment: Bug 1429603: Removed unused balrog code from desktop L10N mozharness script; r?Callek

Comment 18

[Phabricator Automation]

Comment on attachment 8947223 [details]
Bug 1429603: Removed unused balrog code from desktop L10N mozharness script; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D521#11780

Comment 19

[Phabricator Automation]

Comment on attachment 8947223 [details]
Bug 1429603: Removed unused balrog code from desktop L10N mozharness script; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D521

Comment 20

[Phabricator Automation]

Comment on attachment 8947224 [details]
Bug 1429603: Removed unused balrog code from desktop L10N mozharness script; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D521

Comment 21

[Phabricator Automation]

Comment on attachment 8947246 [details]
Bug 1429603: Remove code for uploading artifacts from buildbot to taskcluster; r?jlund

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D523

Comment 22

[Phabricator Automation]

Comment on attachment 8947289 [details]
Bug 1429603: Removed unused balrog code from mobile L10N mozharness script; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D533

Comment 23

[Phabricator Automation]

Comment on attachment 8947310 [details]
Bug 1429603: Remove overriden `upload_env` configuration from L10N mozharness configs; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D535

Comment 24

[Phabricator Automation]

Comment on attachment 8947311 [details]
Bug 1429603: Remove old staging release mozharness L10N configs; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D536

Comment 25

[Phabricator Automation]

Comment on attachment 8947312 [details]
Bug 1429603: Remove unused `post_upload_extra`, `upload_environment` and `base_post_upload_cmd` from L10N mozharness scripts; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D537

Comment 26

[Phabricator Automation]

Comment on attachment 8947245 [details]
Bug 1429603: Get rid of mock references in desktop L10N mozharness script; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D522

Comment 27

[Phabricator Automation]

Comment on attachment 8947313 [details]
Bug 1429603: Remove unused `ssh_key_dir` and `stage_product` from L10N mozharness configs; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D538

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9c658eefef9
Removed unused balrog code from desktop L10N mozharness script; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/818afccb3106
Get rid of mock references in desktop L10N mozharness script; r=Callek

Comment 29

[Phabricator Automation]

Attachment: Bug 1429603: Simplify generation of balrog properties in mozharness; r?jlund

Comment 30

[Phabricator Automation]

Attachment: Bug 1429603: Stop looking at properties from buildbot when generating balrog properties in mozharness; r?jlund

Comment 31

[Phabricator Automation]

Attachment: Bug 1429603: Set `hashType` in balrog properties in one place in mozharness; r?Callek,jlund

Comment 32

[Phabricator Automation]

Attachment: Bug 1429603: Get rid of unused builduid in mozharness; r?jlund

Comment 33

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d9c658eefef9
https://hg.mozilla.org/mozilla-central/rev/818afccb3106

Comment 34

[Phabricator Automation]

Comment on attachment 8950129 [details]
Bug 1429603: Set `hashType` in balrog properties in one place in mozharness; r?Callek,jlund

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D577

Comment 35

[Phabricator Automation]

Comment on attachment 8947377 [details]
Bug 1429603: Remove subsitations in `upload_env` for desktop L10N mozharness scripts; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D542

Comment 36

[Phabricator Automation]

Comment on attachment 8947378 [details]
Bug 1429603: Remove always false `update_gecko_source_to_enUS` from L10N mozharness scripts; r?Callek

Justin Wood (:Callek) has approved the revision.

https://phabricator.services.mozilla.com/D543

Comment 37

[Phabricator Automation]

Comment on attachment 8944585 [details]
Bug 1429603: Removed unsued `virtualenv_python_dll` mozharness config; r?jlund

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D429

Comment 38

[Phabricator Automation]

Comment on attachment 8947347 [details]
Bug 1429603: Remove support for construct `POST_UPLOAD_CMD` in mozharness builds scripts; r?jlund

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D540

Comment 39

[Phabricator Automation]

Comment on attachment 8950127 [details]
Bug 1429603: Simplify generation of balrog properties in mozharness; r?jlund

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D575

Comment 40

[Phabricator Automation]

Comment on attachment 8950128 [details]
Bug 1429603: Stop looking at properties from buildbot when generating balrog properties in mozharness; r?jlund

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D576

Comment 41

[Phabricator Automation]

Comment on attachment 8950130 [details]
Bug 1429603: Get rid of unused builduid in mozharness; r?jlund

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D578

Comment 42

[Phabricator Automation]

Comment on attachment 8947290 [details]
Bug 1429603: Removed unused balrog code helper methods from mozhanress; r?jlund

Jordan Lund (:jlund) has approved the revision.

https://phabricator.services.mozilla.com/D534

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ceaba8f41d0
Remove code for uploading artifacts from buildbot to taskcluster; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce4939c349a9
Removed unused balrog code from mobile L10N mozharness script; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/5181c7bdd600
Removed unused balrog code helper methods from mozhanress; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/8025f5e9be27
Remove overriden `upload_env` configuration from L10N mozharness configs; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ec320951dc9
Remove old staging release mozharness L10N configs; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8123dc4f1f2
Remove unused `post_upload_extra`, `upload_environment` and `base_post_upload_cmd` from L10N mozharness scripts; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/7480609a95ae
Remove unused `ssh_key_dir` and `stage_product` from L10N mozharness configs; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee3ea2965a24
Remove support for construct `POST_UPLOAD_CMD` in mozharness builds scripts; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/aec7c335eab1
Simplify generation of balrog properties in mozharness; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f1b4a72d48a
Stop looking at properties from buildbot when generating balrog properties in mozharness; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/0aec8ceb112f
Set `hashType` in balrog properties in one place in mozharness; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/c550de20b6c7
Get rid of unused builduid in mozharness; r=jlund
https://hg.mozilla.org/integration/mozilla-inbound/rev/27f83ac88526
Remove subsitations in `upload_env` for desktop L10N mozharness scripts; r=Callek
https://hg.mozilla.org/integration/mozilla-inbound/rev/90b727b890e0
Remove always false `update_gecko_source_to_enUS` from L10N mozharness scripts; r=Callek

Comment 44

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7ceaba8f41d0
https://hg.mozilla.org/mozilla-central/rev/ce4939c349a9
https://hg.mozilla.org/mozilla-central/rev/5181c7bdd600
https://hg.mozilla.org/mozilla-central/rev/8025f5e9be27
https://hg.mozilla.org/mozilla-central/rev/9ec320951dc9
https://hg.mozilla.org/mozilla-central/rev/a8123dc4f1f2
https://hg.mozilla.org/mozilla-central/rev/7480609a95ae
https://hg.mozilla.org/mozilla-central/rev/ee3ea2965a24
https://hg.mozilla.org/mozilla-central/rev/aec7c335eab1
https://hg.mozilla.org/mozilla-central/rev/8f1b4a72d48a
https://hg.mozilla.org/mozilla-central/rev/0aec8ceb112f
https://hg.mozilla.org/mozilla-central/rev/c550de20b6c7
https://hg.mozilla.org/mozilla-central/rev/27f83ac88526
https://hg.mozilla.org/mozilla-central/rev/90b727b890e0

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf662dbf4bc7
Removed unsued `virtualenv_python_dll` mozharness config; r=jlund

Comment 46

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bf662dbf4bc7