452472 - write a BuildFactory containing all the necessary steps to create and upload a source tarball and hg bundle for mercurial based releases

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[[e-mail] (:bhearsum)]

Comment 1

[[e-mail] (:bhearsum)]

Attachment: source factory, minus uploading

Not much of note here other than the refactoring. The repoName/pushRepo logic is going to be needed elsewhere, so I factored it into a base class for the rest of the factories to inherit from.

As for the Source factory itself, it's a pretty simple series of ShellCommands, taken from the 3.1a1 + a2 build notes. Notably, there is no uploading yet - I'm awaiting Ted's 'upload' Makefile target before I do that.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Could you make this support https while you're factoring it ?

+    def getPushRepo(repo):
+        if repo.startswith('http'):
+            return repo.replace('http', 'ssh')
+        else:
+            return repo

Comment 3

[[e-mail] (:bhearsum)]

Attachment: [checked in] same as before, support http + https properly

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 337665 [details] [diff] [review]
[checked in] same as before, support http + https properly

Checking in factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.14; previous revision: 1.13
done

Comment 5

[Robert Kaiser]

FYI, I just filed bug 456373 to move source tarball generation into a makefile target.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: upload the source packages automatically

Comment 7

[[e-mail] (:bhearsum)]

Attachment: master-side patch

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 354701 [details] [diff] [review]
upload the source packages automatically

>         self.addStep(ShellCommand,
>+         command=['mkdir', 'source'],
>+         workdir='.',
>+         haltOnFailure=True
>+        )

We should probably insulate ourselves from failure here by adding a ShellCommand before this to rm an existing source/ dir.

r+ with that change.

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 354702 [details] [diff] [review]
master-side patch

changeset:   619:a5fbe3a19136

Comment 10

[[e-mail] (:bhearsum)]

Attachment: source upload patch w/ cleanup

Checking in process/factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.66; previous revision: 1.65
done

Comment 11

[[e-mail] (:bhearsum)]

All done here now.

Comment 12

[Robert Kaiser]

would have been a good idea to use "make source-package" here.

Comment 13

[[e-mail] (:bhearsum)]

Yes, I intend to make that change at some point. Unfortunately, it did not exist when I first wrote this code.