1429625 - Remove decimal places handling and unused methods from textbox[type=number]

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Tim Nguyen :ntim]

As seen in bug 1429573, the following can be removed from the numberbox binding: decimal places handling, increase() and decrease() methods.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.

Review commit: https://reviewboard.mozilla.org/r/211916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211916/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8941671 [details]
Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211916/diff/1-2/

Comment 3

[Tim Nguyen :ntim]

Comment on attachment 8941671 [details]
Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211916/diff/2-3/

Comment 4

[Tim Nguyen :ntim]

ni? Paenglab about potential comm-central changes.

Comment 5

[Richard Marti (:Paenglab)]

Thank you for the info. I found only one place where we use decimal places: https://dxr.mozilla.org/comm-central/source/mail/components/preferences/notifications.xul#40

This should be easy to change.

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 8941671 [details]
Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211916/diff/3-4/

Comment 7

[Tim Nguyen :ntim]

Neil, are you able to review this ?

Comment 8

[:Paolo Amadini]

Comment on attachment 8941671 [details]
Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.

https://reviewboard.mozilla.org/r/211916/#review220476

Thanks!

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8941671 [details]
Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211916/diff/4-5/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5beaa39e3c58
Remove decimal places handling and unused methods from numberbox binding. r=Paolo

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5beaa39e3c58

Comment 12

[Axel Grude [:realRaven]]

this was useful for my restartless Addon MenuOnTop (setting border radius in multiples of em). Now it's broken so I need to change to px. why remove something so useful?