Remove decimal places handling and unused methods from textbox[type=number]

RESOLVED FIXED in Firefox 60

Status

()

task
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Blocks 1 bug)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

As seen in bug 1429573, the following can be removed from the numberbox binding: decimal places handling, increase() and decrease() methods.
Summary: Remove unused features from textbox[type=number] → Remove decimal places handling and unused methods from textbox[type=number]
ni? Paenglab about potential comm-central changes.
Flags: needinfo?(richard.marti)
Thank you for the info. I found only one place where we use decimal places: https://dxr.mozilla.org/comm-central/source/mail/components/preferences/notifications.xul#40

This should be easy to change.
Flags: needinfo?(richard.marti)
Attachment #8941671 - Flags: review?(dao+bmo) → review?(enndeakin)
Neil, are you able to review this ?
Flags: needinfo?(enndeakin)
Attachment #8941671 - Flags: review?(enndeakin) → review?(paolo.mozmail)
Comment on attachment 8941671 [details]
Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.

https://reviewboard.mozilla.org/r/211916/#review220476

Thanks!
Attachment #8941671 - Flags: review?(paolo.mozmail) → review+
Flags: needinfo?(enndeakin)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5beaa39e3c58
Remove decimal places handling and unused methods from numberbox binding. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/5beaa39e3c58
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Depends on: 1432462
Blocks: 1429573
this was useful for my restartless Addon MenuOnTop (setting border radius in multiples of em). Now it's broken so I need to change to px. why remove something so useful?
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.