Closed
Bug 1429625
Opened 7 years ago
Closed 7 years ago
Remove decimal places handling and unused methods from textbox[type=number]
Categories
(Toolkit :: UI Widgets, task)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file)
As seen in bug 1429573, the following can be removed from the numberbox binding: decimal places handling, increase() and decrease() methods.
Assignee | ||
Updated•7 years ago
|
Summary: Remove unused features from textbox[type=number] → Remove decimal places handling and unused methods from textbox[type=number]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
ni? Paenglab about potential comm-central changes.
Flags: needinfo?(richard.marti)
Comment 5•7 years ago
|
||
Thank you for the info. I found only one place where we use decimal places: https://dxr.mozilla.org/comm-central/source/mail/components/preferences/notifications.xul#40
This should be easy to change.
Flags: needinfo?(richard.marti)
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8941671 -
Flags: review?(dao+bmo) → review?(enndeakin)
Assignee | ||
Updated•7 years ago
|
Attachment #8941671 -
Flags: review?(enndeakin) → review?(paolo.mozmail)
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8941671 [details]
Bug 1429625 - Remove decimal places handling and unused methods from numberbox binding.
https://reviewboard.mozilla.org/r/211916/#review220476
Thanks!
Attachment #8941671 -
Flags: review?(paolo.mozmail) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(enndeakin)
Comment 10•7 years ago
|
||
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5beaa39e3c58
Remove decimal places handling and unused methods from numberbox binding. r=Paolo
Comment 11•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment 12•7 years ago
|
||
this was useful for my restartless Addon MenuOnTop (setting border radius in multiples of em). Now it's broken so I need to change to px. why remove something so useful?
Assignee | ||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•