Closed Bug 1429806 Opened 2 years ago Closed 2 years ago

Update webrender to eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf

Categories

(Core :: Graphics: WebRender, enhancement, P3)

59 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(6 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1428766 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Blocks: 1400384
Blocks: 1429524
Blocks: 1429411
Blocks: 1419065
Blocks: 1419528
WR @ eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf with build fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fbab937070adb9e3742b5566d73104a54093d00
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dd0ef5924946879f415cf938b40d09be5cd56be

Linux reftests are all orange, looks like in a lot of them characters are getting rendered sideways.
Attached patch clear WR GlyphOptions flags (obsolete) — Splinter Review
A new flags field was added to GlyphOptions. A further patch is needed to actually use this, but until that gets reviewed, we need to at least clear these flags so they're not filled with junk.
Attachment #8942916 - Flags: review?(bugmail)
Comment on attachment 8942916 [details] [diff] [review]
clear WR GlyphOptions flags

Review of attachment 8942916 [details] [diff] [review]:
-----------------------------------------------------------------

This works, thanks
Attachment #8942916 - Flags: review?(bugmail) → review+
WR @ eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf with Lee's fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fbb09f0d6142113e33f97eec573ed57d15d42ff
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc96e994eb0c956ad68cd8099700fa0f67374ca2

Much better. There's still R2 and R8 unexpected-pass because that try push didn't include the patch from bug 1419065. I'll pull that in as well.
WR @ eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf with the reftest updates

https://treeherder.mozilla.org/#/jobs?repo=try&revision=61fa59a85db368a044f0f67e11d8dc8dd57857cb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2e41ae653bdd61627a8062466060e7b8bffff71

Green. The windows reftests disappeared because of buildbot issues that :Callek is investigating.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf
Version: unspecified → 59 Branch
Comment on attachment 8942955 [details]
Bug 1429806 - Initialize new field in WR GlyphOptions introduced in WR PR 2288.

https://reviewboard.mozilla.org/r/213224/#review218916
Attachment #8942955 - Flags: review?(bugmail) → review+
Comment on attachment 8942957 [details]
Bug 1429806 - Update annotations for the fix of webrender border problems (PR#2292).

https://reviewboard.mozilla.org/r/213228/#review218920
Attachment #8942957 - Flags: review?(bugmail) → review+
Comment on attachment 8942952 [details]
Bug 1429806 - Update webrender to commit eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf.

https://reviewboard.mozilla.org/r/213218/#review218938
Attachment #8942952 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8942953 [details]
Bug 1429806 - Update for API change in WR PR 2276.

https://reviewboard.mozilla.org/r/213220/#review218940
Attachment #8942953 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8942954 [details]
Bug 1429806 - Update fuzz numbers for changes in WR PRs 2284 and 2285.

https://reviewboard.mozilla.org/r/213222/#review218942
Attachment #8942954 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8942956 [details]
Bug 1429806 - Update for API change in WR PR 2295.

https://reviewboard.mozilla.org/r/213226/#review218944
Attachment #8942956 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb1da388dea0
Update webrender to commit eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c69d7b2282a2
Update for API change in WR PR 2276. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/4f86d2bfab76
Update fuzz numbers for changes in WR PRs 2284 and 2285. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8dee0068044c
Initialize new field in WR GlyphOptions introduced in WR PR 2288. r=kats
https://hg.mozilla.org/integration/autoland/rev/4f05b2eb06ca
Update for API change in WR PR 2295. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/243b7c8aa2e7
Update annotations for the fix of webrender border problems (PR#2292). r=kats
You need to log in before you can comment on or make changes to this bug.