1429806 - Update webrender to eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1428766 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 722e8b104bf99d29d61ecb1fe456eebe89ad81fd

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c8f01e31451686a0ccc1b7de1bf6869d8597c09
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecafe8e5b9d895e6372d23b282efca27b6031987

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 722e8b104bf99d29d61ecb1fe456eebe89ad81fd

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e19886aabe39def76e7543de2903b29ae1bc60e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e7c24327416ea11ad5acebbf7e350d37b33e0bb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=991f3c323b6c90853e4a88242d0c545df7897281
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ad97dfa0f555db96489987d8f320c75a81923dd

Green

I should really change my script to run per-merge-commit instead of every 8 hours.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ 9e6cbad4b28b343a63e67f281b934725321ba0ad

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12e45ed4c249cab5c990181aa40d36551e65f0a9
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f4e4d77500d7b14fbf9fbdb62dfacc177899683

Bustage, due to s/A8/R8/ in servo/webrender#2276

WR @ 4a5402212b7b01c3b5827a0cf521b51dea48e351 with that fixed

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6cb1349280ca24eaca03c4edb2a5eaf70ba1fef
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a784f9efa0cd74de962792f88e8cf0ca55c1f995

Green so far

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ e0f2bf1aff123f9e01b5ca08c5143b97b948ceb4

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f67e219032b38851e76f495f33143a47daf4987
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a062b84b24c64947388a531e8d1affb06621cef7

Green

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ e0f2bf1aff123f9e01b5ca08c5143b97b948ceb4

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eed28a1156bde7642c7e0ddf3b7fb84978ce8089
https://treeherder.mozilla.org/#/jobs?repo=try&revision=331d1a2a021db58483df98297bc274ba07422c9c

Green

WR @ cb4c246fd34a09c9436f986d37a7e45d68f2322e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ef419424d32d9161433e6d9377cba1456676135
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d23258679eb84006922eba6c0b6b8358ff0bdb99

Green

WR @ 2acfa55f11f51427a6b62b3fc93252365288d1a5

https://treeherder.mozilla.org/#/jobs?repo=try&revision=136985a998f8d2d52df19ff01fdc274a97b241bb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15b867bfb500d1190c1ddb8c6366c71518f8f383

Green

WR @ f1cecd7fbb8b53d12d2f549ac3de4e9a820be775

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b88af96094eb721b9a12456515444e54ec2a700a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=727078da44aab558f9183ca797010c7c2b5dd23c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d99231a617f9268e52344126c82df020a490872
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3a395e4b936b2a30ece26fe1b4ceff3a5748989

R4 unexpected pass - reduction in fuzzy pixels on layout/reftests/css-break/box-decoration-break-with-inset-box-shadow-1.html, from servo/webrender#2284. Rest is green

Comment 6

[Kartikaya Gupta (email:[e-mail])]

WR @ e16c2488146d7307a2cb79e79a1a41dd2fa3850a

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82f4cdaf773fc7840b5bf7d044750f2184051cef

R4, same test as before but it was also affected by servo/webrender#2285

WR @ 0acc7ca266d84c9ca0488d584889949000766597

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eea6153ea469849e04934e35df58614e753a14d5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66ae514d7b23b0254754420e47190e0369d7f3f5

Bustage, my fault - it's from servo/webrender#2295

WR @ eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf

https://treeherder.mozilla.org/#/jobs?repo=try&revision=918e60d7bad94f22bb95892d6cadbe1de931c46e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa2640cf8697c9b803a0cee2d2c243852190145e

Ditto

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf with build fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fbab937070adb9e3742b5566d73104a54093d00
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dd0ef5924946879f415cf938b40d09be5cd56be

Linux reftests are all orange, looks like in a lot of them characters are getting rendered sideways.

Comment 8

[Lee Salzman [:lsalzman]]

Attachment: clear WR GlyphOptions flags

A new flags field was added to GlyphOptions. A further patch is needed to actually use this, but until that gets reviewed, we need to at least clear these flags so they're not filled with junk.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8942916 [details] [diff] [review]
clear WR GlyphOptions flags

Review of attachment 8942916 [details] [diff] [review]:
-----------------------------------------------------------------

This works, thanks

Comment 10

[Kartikaya Gupta (email:[e-mail])]

WR @ eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf with Lee's fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fbb09f0d6142113e33f97eec573ed57d15d42ff
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc96e994eb0c956ad68cd8099700fa0f67374ca2

Much better. There's still R2 and R8 unexpected-pass because that try push didn't include the patch from bug 1419065. I'll pull that in as well.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

WR @ eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf with the reftest updates

https://treeherder.mozilla.org/#/jobs?repo=try&revision=61fa59a85db368a044f0f67e11d8dc8dd57857cb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2e41ae653bdd61627a8062466060e7b8bffff71

Green. The windows reftests disappeared because of buildbot issues that :Callek is investigating.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1429806 - Update webrender to commit eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf.

Review commit: https://reviewboard.mozilla.org/r/213218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213218/

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1429806 - Update for API change in WR PR 2276.

Review commit: https://reviewboard.mozilla.org/r/213220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213220/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1429806 - Update fuzz numbers for changes in WR PRs 2284 and 2285.

Both these PRs affected the same test.

Review commit: https://reviewboard.mozilla.org/r/213222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213222/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1429806 - Initialize new field in WR GlyphOptions introduced in WR PR 2288.

Review commit: https://reviewboard.mozilla.org/r/213224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213224/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1429806 - Update for API change in WR PR 2295.

Review commit: https://reviewboard.mozilla.org/r/213226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213226/

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1429806 - Update annotations for the fix of webrender border problems (PR#2292).

Review commit: https://reviewboard.mozilla.org/r/213228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213228/

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8942955 [details]
Bug 1429806 - Initialize new field in WR GlyphOptions introduced in WR PR 2288.

https://reviewboard.mozilla.org/r/213224/#review218916

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8942957 [details]
Bug 1429806 - Update annotations for the fix of webrender border problems (PR#2292).

https://reviewboard.mozilla.org/r/213228/#review218920

Comment 20

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8942952 [details]
Bug 1429806 - Update webrender to commit eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf.

https://reviewboard.mozilla.org/r/213218/#review218938

Comment 21

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8942953 [details]
Bug 1429806 - Update for API change in WR PR 2276.

https://reviewboard.mozilla.org/r/213220/#review218940

Comment 22

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8942954 [details]
Bug 1429806 - Update fuzz numbers for changes in WR PRs 2284 and 2285.

https://reviewboard.mozilla.org/r/213222/#review218942

Comment 23

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8942956 [details]
Bug 1429806 - Update for API change in WR PR 2295.

https://reviewboard.mozilla.org/r/213226/#review218944

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1da388dea0
Update webrender to commit eb9e1702df4b6dc036b649b3dd32ccc4bfbe43bf. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c69d7b2282a2
Update for API change in WR PR 2276. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/4f86d2bfab76
Update fuzz numbers for changes in WR PRs 2284 and 2285. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8dee0068044c
Initialize new field in WR GlyphOptions introduced in WR PR 2288. r=kats
https://hg.mozilla.org/integration/autoland/rev/4f05b2eb06ca
Update for API change in WR PR 2295. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/243b7c8aa2e7
Update annotations for the fix of webrender border problems (PR#2292). r=kats

Comment 25

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bb1da388dea0
https://hg.mozilla.org/mozilla-central/rev/c69d7b2282a2
https://hg.mozilla.org/mozilla-central/rev/4f86d2bfab76
https://hg.mozilla.org/mozilla-central/rev/8dee0068044c
https://hg.mozilla.org/mozilla-central/rev/4f05b2eb06ca
https://hg.mozilla.org/mozilla-central/rev/243b7c8aa2e7