1429808 - Text selection change events are no longer emitted for document content

Status: RESOLVED DUPLICATE of bug 1446699

(Core :: Disability Access APIs, defect)

Description

[Joanmarie Diggs]

Steps to reproduce:
1. Launch Firefox
2. Launch Accerciser and enable event monitoring for object:text-selection-changed events
3. Use the mouse or keyboard to select/highlight text within the location bar
4. Use the mouse or keyboard to select/highlight text within a document

Expected results: For both steps 3 and 4, Accerciser would print out object:text-selection-changed events.

Actual results: Things work as expected for step 3, but no events are being emitted for step 4.

This is a regression, but I'm afraid I don't know when it was introduced. I see it in both Nightly and 57.0.4. Perhaps it's an uncaught regression from the multi-process switch??

Impact: Orca relies heavily upon this event to present text selection changes to the user.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Sounds like we may need more tests here: https://searchfox.org/mozilla-central/source/accessible/tests/mochitest/textselection

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

or rather browser/ (since we should test e10s codepath)

Comment 3

[Joanmarie Diggs]

This works as expected in 52.5.3/"ESR"

Comment 4

[alexander :surkov (:asurkov)]

Both main and content process seems end up calling FireTextChangeEvent method: content process [1] and main process [2]. The code path is a standard one and shared with Windows as well [3], which appears working. 

So if anyone having a linux build at hands could try to set up breakpoint at MaiAtkObject::FireTextChangeEvent and see if we ever reach there, before I set up my own linux build, then it'd be very helpful.

[1] https://dxr.mozilla.org/mozilla-central/source/accessible/atk/AccessibleWrap.cpp?q=FireTextChangeEvent&redirect_type=direct#1568
[2] https://dxr.mozilla.org/mozilla-central/source/accessible/atk/AccessibleWrap.cpp?q=FireTextChangeEvent&redirect_type=direct#1587
[3] https://dxr.mozilla.org/mozilla-central/source/accessible/ipc/DocAccessibleParent.cpp#335

Comment 5

[Samuel Thibault]

I have a 57.0.1 build were I have the issue too. I put a breakpoint on MaiAtkObject::FireTextChangeEvent but didn't got it triggered, neither with the location bar selection nor with the document selection. Typing text in the location bar did trigger it.

Comment 6

[Joanmarie Diggs]

A text-change event should be insertions, deletions, and replacements; not selection changes. (Right?)

Comment 7

[alexander :surkov (:asurkov)]

sorry, I totally misread the bug. So here's a problem I think. We fire "selection_changed" instead of "text_selection_changed" [1].

[1] https://dxr.mozilla.org/mozilla-central/source/accessible/atk/AccessibleWrap.cpp#1517

Comment 8

[James Teh [:Jamie]]

(In reply to alexander :surkov (:asurkov) from comment #7)

sorry, I totally misread the bug. So here's a problem I think. We fire
"selection_changed" instead of "text_selection_changed" [1].

We fixed that in bug 1446699, which should have addressed this. If not, please reopen.