Closed Bug 1429859 Opened 3 years ago Closed 3 years ago
Due to a bug we sometime send a request that got 425 as early-data again
No description provided.
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Attachment #8941909 - Flags: review?(mcmanus)
Attachment #8941909 - Flags: review?(mcmanus) → review+
Priority: -- → P1
Comment on attachment 8941909 [details] [diff] [review] bug_1429859.patch Approval Request Comment [Feature/Bug causing the regression]: bug 1406908 [User impact if declined]: If firefox send some request with tls1.3 early-data, it may happen that server replies with 425 Too Early. Firefox should resend the request but not as early-data. Due to this bug firefox sometimes resend the request in early-data. In that case user will see error 425 as a response. [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]:none [Is the change risky?]: no, it is a one line patch [Why is the change risky/not risky?]: [String changes made/needed]:
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9d7620e3e096 Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus
Comment on attachment 8941909 [details] [diff] [review] bug_1429859.patch Fix an issue which will cause server to reply with 425 too early. Beta58+
https://hg.mozilla.org/releases/mozilla-beta/rev/0c5b5676912d (FIREFOX_58b_RELBRANCH) Previous beta changeset had landed on wrong branch and got backed out in https://hg.mozilla.org/releases/mozilla-beta/rev/09bab9dac2557fa568c7072299df0527f073043e
You need to log in before you can comment on or make changes to this bug.