1429946 - Use folderPane.js to convert SeaMonkeys rdf-trees to js

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

XUL template and datasource rdf removal broke SeaMonkey Mail/News completly. Unless we want to reinvent the wheel or someone has a better less costly idea we need to switch to Thunderbirds folderpane.js.

+++ This bug was initially created as a clone of Bug #464710 +++

This is the first real test of the js-folder-pane's extensibility. The offline-folders dialog, along with the saved-search scope dialog each want to display trees of folders, though not the specific lists of folders provided by the main-window's modes.

These patches show how to add additional modes to folderPane.js, and thereby eliminates these rdf-driven trees.

Note that these changes were in the kill-rdf branch as 654:41ed0521f6f8 and 656:cf3baa820a87

Comment 1

[Frank-Rainer Grahl (:frg)]

Oh btw the sidebar and help viewer are also broken :(

Comment 3

[Ian Neal]

Attachment: 1429946-port464710-2538.patch

[Approval Request Comment]
Regression caused by (bug #): 464710
User impact if declined: virtual / offline doesn't work / display properly
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9210528 [details] [diff] [review]
1429946-port464710-2538.patch

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5ce8529cbffc
Use folderPane.js to convert SeaMonkeys rdf-trees to js. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a12daa0673cfe4ad2cade47f389e1fc8a5f9e7a9
Use folderPane.js to convert SeaMonkeys rdf-trees to js. r=frg a=frg