Closed Bug 1430021 Opened 2 years ago Closed 2 years ago

Make HTMLEditRules not derived from nsIEditActionListener

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(2 files, 1 obsolete file)

As far as I tested, HTMLEditRules is the first edit action listener. We should call only necessary methods directly.
Attachment #8942837 - Attachment is obsolete: true
Attachment #8942837 - Flags: review?(m_kato)
Comment on attachment 8942838 [details]
Bug 1430021 - part 2: Make HTMLEditRules not derived from nsIEditActionListener

https://reviewboard.mozilla.org/r/213056/#review219578
Attachment #8942838 - Flags: review?(m_kato) → review+
Oh, part 1 and part 3 are hidden! MozReview's bug?? I'll request reviews again.
Er, there is no part 3. Only part 1 was hidden.
Comment on attachment 8943545 [details]
Bug 1430021 - part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase

https://reviewboard.mozilla.org/r/213892/#review219906
Attachment #8943545 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/149afa9d22d0
part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase r=m_kato
https://hg.mozilla.org/integration/autoland/rev/88a6a578cd7b
part 2: Make HTMLEditRules not derived from nsIEditActionListener r=m_kato
https://hg.mozilla.org/mozilla-central/rev/149afa9d22d0
https://hg.mozilla.org/mozilla-central/rev/88a6a578cd7b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.