1430021 - Make HTMLEditRules not derived from nsIEditActionListener

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

As far as I tested, HTMLEditRules is the first edit action listener. We should call only necessary methods directly.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=972982708d542accbdf2d15b36f2c8c5fe8ebaee

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3659014fceb1d92eee4ed332a47429dd3ade78a7

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8440daaf2eb3a2cb237fe8264dd3aa895dd85cb4

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e92432e50f7deea71ddc12d03e0bc4b64093497

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=146e8165586c8a217354855ad3a80e682cfce019

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e70ef6cd1ccbf04ed55af78c15c847b18578e844

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f0f6c18fb1e6c63caa41793be98b64d6df55298

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1430021 - part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase

For calling some methods of mRules from EditorBase, let's move mRules member
from TextEditor to EditorBase.

Unfortunately, TextEditRules.h depends on EditAction which is declared in
EditorBase.h and that caused unnecessary include hell of EditorBase.h.  So,
let's move it to an independent header file.

Review commit: https://reviewboard.mozilla.org/r/213054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213054/

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1430021 - part 2: Make HTMLEditRules not derived from nsIEditActionListener

HTMLEditRules implements only some of nsIEditActionListener and this is always
first edit action listener.  So, if we make EditorBase treat HTMLEditRules
directly before notifying edit action listeners, we can save a lot of runtime
cost (virtual calls especially unnecessary, copying array of edit action
listeners with strong pointer, redundant QIs), although the code becomes not
beautiful.

Perhaps, we should do same thing to nsTextServicesDocument and
mozInlineSpellChecker in other bugs.

Review commit: https://reviewboard.mozilla.org/r/213056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213056/

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8942838 [details]
Bug 1430021 - part 2: Make HTMLEditRules not derived from nsIEditActionListener

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213056/diff/1-2/

Comment 11

[Makoto Kato [:m_kato]]

Comment on attachment 8942838 [details]
Bug 1430021 - part 2: Make HTMLEditRules not derived from nsIEditActionListener

https://reviewboard.mozilla.org/r/213056/#review219578

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, part 1 and part 3 are hidden! MozReview's bug?? I'll request reviews again.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Er, there is no part 3. Only part 1 was hidden.

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1430021 - part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase

For calling some methods of mRules from EditorBase, let's move mRules member
from TextEditor to EditorBase.

Unfortunately, TextEditRules.h depends on EditAction which is declared in
EditorBase.h and that caused unnecessary include hell of EditorBase.h.  So,
let's move it to an independent header file.

Review commit: https://reviewboard.mozilla.org/r/213892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213892/

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8942838 [details]
Bug 1430021 - part 2: Make HTMLEditRules not derived from nsIEditActionListener

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213056/diff/2-3/

Comment 16

[Makoto Kato [:m_kato]]

Comment on attachment 8943545 [details]
Bug 1430021 - part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase

https://reviewboard.mozilla.org/r/213892/#review219906

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/149afa9d22d0
part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase r=m_kato
https://hg.mozilla.org/integration/autoland/rev/88a6a578cd7b
part 2: Make HTMLEditRules not derived from nsIEditActionListener r=m_kato

Comment 18

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/149afa9d22d0
https://hg.mozilla.org/mozilla-central/rev/88a6a578cd7b