1430122 - Custom tab close button is too large compared to the other buttons

Status: VERIFIED FIXED

(Firefox for Android :: Custom Tabs, defect, P5)

Description

[Oana Horvath]

Attachment: previous button.png

Device: Samsung Galaxy S8 (Android 7.0)
Build: Nightly 59.0a1 (2018-01-12);

Steps to reproduce:
1. Open a link in a custom tab (default browser: Nightly).
2. Check the close button.

Expected result:
See the "previous button" screenshot.

Actual result:
The new close button is too large compared to the previous and the other buttons used.

Comment 1

[Oana Horvath]

Attachment: current button.png

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Please help advise. Thanks!

Comment 4

[Michael Comella (:mcomella) [needinfo or I won't see it]]

[triage] Non-critical.

Comment 5

[Carol Huang [:Carol]]

I think it's using the wrong resolution images. Could someone help provide the name of the icon asset (image)? so i could check, thanks!

Comment 6

[rugk]

It seems this was introduced with FF59, it was correct in FF58, at least.

Comment 7

[:sdaswani]

NI Barbara and Andreas, should we fix this for 61 or 62?

Comment 8

[Andreas Bovens [:abovens]]

Ideally 61, but I can live with 62 as well.

Comment 9

[Andreas Bovens [:abovens]]

I would like to get this fixed soon, as it's very visible. Can it be prioritized?

Comment 10

[:sdaswani]

Andreas, the Softvision team is currently prioritizing the Android O work: https://trello.com/c/izAPXSyJ/506-fennec-target-sdk-version-62 

I can have one of them work on this issue over that work if you feel it is a bigger priority.

Comment 11

[Andreas Bovens [:abovens]]

Once that's done, let's tackle this issue.

Comment 12

[:sdaswani]

Vlad, can you please get this on your prioritized list (under the O work)?

Comment 13

[:sdaswani]

Andrei, can you prioritize this immediately after all the API upgrade crash work?

Comment 14

[Andrei Lazar]

Sure thing, will fix this ASAP!

Comment 15

[Andreas Bovens [:abovens]]

Thanks, Andrei.

Comment 16

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 17

[Andrei Lazar]

Attachment: Bug 1430122 Custom tab close button is too large compared to the other buttons r?sdaswani

Comment 18

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9003173 [details]
Bug 1430122 Custom tab close button is too large compared to the other buttons r?sdaswani

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 19

[Cosmin Sabou [:CosminS]]

Please review your patch for this bug. Phabricator says the following:

This revision is not associated with a repository. In order to land, a revision must be associated with a repository on Phabricator.
This diff does not have the proper author information uploaded to Phabricator. This can happen if the diff was created using the web UI, or a non standard client. The author should re-upload the diff to Phabricator using the "arc diff" command.

Comment 20

[Andrei Lazar]

Attachment: Bug 1430122 Custom tab close button is too large compared to the other buttons.

Resized the close button manually.

Comment 21

[Vlad Baicu]

Comment on attachment 9004239 [details]
Bug 1430122 Custom tab close button is too large compared to the other buttons.

Vlad Baicu has approved the revision.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8df42395ed8
Custom tab close button is too large compared to the other buttons. r=VladBaicu

Comment 23

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/c8df42395ed8

Comment 24

[Oana Horvath]

Verified as fixed on Nightly 63 (2018-29-08).
Devices:
Sony Xperia Z5 Premium (Android 6.0.1)
Google Pixel (Android 9)

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Seems like a trivial ride-along fix we could take for RC2. Please nominate this for release approval if you agree.

Comment 26

[Andrei Lazar]

Comment on attachment 9004239 [details]
Bug 1430122 Custom tab close button is too large compared to the other buttons.

Approval Request Comment
[Feature/Bug causing the regression]: Custom tab close button is too large
[User impact if declined]: This causes a bad user experience
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Because it's just an image
[String changes made/needed]: No

Comment 27

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9004239 [details]
Bug 1430122 Custom tab close button is too large compared to the other buttons.

Simple polish fix for custom tabs. Approved for 62 RC2.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/7682ad2849f6

Comment 29

[Oana Horvath]

Verified as fixed on RC 62.0 build 2.
Device: Sony Xperia Z5 Premium (Android 6.0.1)
Google Pixel (Android 9)