1430132 - Top Sites context menu button is wrongly displayed when you move the Top Site to the left

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: context menu still displayed when moving a top site to the left.gif

[Affected versions]:
- Firefox 59.0a1 Build ID 20180111220102

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a clean new profile.

[Steps to reproduce]:
1. Start the browser with the profile from prerequisites and open a new profile.
2. Drag the last Top Site to the left and observe the top-right part of the tile.
 
[Expected results]:
- The context menu button is not displayed.

[Actual results]:
- The context menu button remains displayed.

[Notes]:
- The issue is not reproducible if you move the Top Site to the right.
- The issue is also reproducible with the additional options from the Top Sites Edit menu.
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3937

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/f2f2ca387c8606ab7b4e64113eca3d8b5ae70abe
Fix Bug 1430132 - close context menu on drag start

https://github.com/mozilla/activity-stream/commit/67697b5401233443c00573a8c195831819b2deef
Merge pull request #3937 from rlr/bug1430132/context-menu-open

Fix Bug 1430132 - close context menu on drag start

Comment 3

[Ed Lee :Mardak]

I don't think this was actually fixed by https://github.com/mozilla/activity-stream/pull/3937 but the thing actually being fixed was bug 1403947.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3944

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/8ce01447d61af678ef7cfd1d7f127c02453cbd4c
Fix Bug 1430132 - dont show hover/active/focus state during DnD

https://github.com/mozilla/activity-stream/commit/68627453a839d7a21db33ea1e108bd90a12d0ccf
Merge pull request #3944 from rlr/bug1430132/dnd-hover-button

Fix Bug 1430132 - dont show hover/active/focus state during DnD

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/549d78378587

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180126035135

I have verified that this issue is no longer reproducible on Windows 10 x64, Ubuntu 14.04 x64 and Mac 10.12 with the latest Nightly build (60.0a1) installed. Now the context menu button is no longer displayed when you move the Top Site to the left.