Closed Bug 1430383 Opened 2 years ago Closed 2 years ago

devtools/server/tests/browser/browser_canvasframe_helper_04.js fails with timeout on win32 debug non-e10s after bug 1193394

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

actually, browser_canvasframe_helper_04.js is disabled on e10s
looks like, the content is not yet ready for synthesizeMouseDown after load event?

the remaining part after `await loaded` is executed in the following microtask checkpoint.
https://hg.mozilla.org/try/rev/4133d526893dd9f9e450f30866d49690db5facc3#l10.18

but I think it's essentially not changed by the patch.
without the bug 1193394 patch, the callstack for the remaining part after `await loaded` is different.
it's outside nsDocumentViewer::LoadComplete.
So, it just need to wait for one event tick, to avoid running the remaining part in the microtask checkpoint for the load event itself,
to make sure the mouse event is properly synthesized.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Just like bug 1430408, added wait after load event.
here I used setTimeout since it's inside content process and it doesn't have executeSoon
Attachment #8943924 - Flags: review?(pbrosset)
Comment on attachment 8943924 [details] [diff] [review]
Wait for the next event tick after load event in devtools/server/tests/browser/browser_canvasframe_helper_04.js

Review of attachment 8943924 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good to me. Thank you.
Attachment #8943924 - Flags: review?(pbrosset) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2df9f222906
Wait for the next event tick after load event in devtools/server/tests/browser/browser_canvasframe_helper_04.js r=pbro
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2df9f22290658f15068ebdfd3f1ecee377e88f7
Bug 1430383 - Wait for the next event tick after load event in devtools/server/tests/browser/browser_canvasframe_helper_04.js r=pbro
https://hg.mozilla.org/mozilla-central/rev/f2df9f222906
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.