1430383 - devtools/server/tests/browser/browser_canvasframe_helper_04.js fails with timeout on win32 debug non-e10s after bug 1193394

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ecce716a4ea50bbb6b7219fe8cf12c202795a78&group_state=expanded&filter-resultStatus=success&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=156136564
> TEST-UNEXPECTED-FAIL | devtools/server/tests/browser/browser_canvasframe_helper_04.js | Test timed out -

Comment 1

[Tooru Fujisawa [:arai]]

actually, browser_canvasframe_helper_04.js is disabled on e10s

Comment 2

[Tooru Fujisawa [:arai]]

looks like, the content is not yet ready for synthesizeMouseDown after load event?

the remaining part after `await loaded` is executed in the following microtask checkpoint.
https://hg.mozilla.org/try/rev/4133d526893dd9f9e450f30866d49690db5facc3#l10.18

but I think it's essentially not changed by the patch.

Comment 3

[Tooru Fujisawa [:arai]]

without the bug 1193394 patch, the callstack for the remaining part after `await loaded` is different.
it's outside nsDocumentViewer::LoadComplete.

Comment 4

[Tooru Fujisawa [:arai]]

So, it just need to wait for one event tick, to avoid running the remaining part in the microtask checkpoint for the load event itself,
to make sure the mouse event is properly synthesized.

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Wait for the next event tick after load event in devtools/server/tests/browser/browser_canvasframe_helper_04.js

Just like bug 1430408, added wait after load event.
here I used setTimeout since it's inside content process and it doesn't have executeSoon

Comment 6

[Patrick Brosset <:pbro>]

Comment on attachment 8943924 [details] [diff] [review]
Wait for the next event tick after load event in devtools/server/tests/browser/browser_canvasframe_helper_04.js

Review of attachment 8943924 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good to me. Thank you.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2df9f222906
Wait for the next event tick after load event in devtools/server/tests/browser/browser_canvasframe_helper_04.js r=pbro

Comment 8

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2df9f22290658f15068ebdfd3f1ecee377e88f7
Bug 1430383 - Wait for the next event tick after load event in devtools/server/tests/browser/browser_canvasframe_helper_04.js r=pbro

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f2df9f222906