1430389 - Remove tree-progressmeter from task view

Status: RESOLVED FIXED

(Calendar :: Tasks, enhancement)

Description

[[:MakeMyDay]]

Let's remove the tree-progressmeter as discussed in bug 1430374.

Comment 1

[[:MakeMyDay]]

Attachment: RemoveProgressMeterFromTaskView-V1.diff

This patch removes the use of progressmeter in the task tree. Instead, percentage values are displyed in the "% Complete" column.

Apart from the current fix, should we rename the column label to "Completeness" along with this change?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: tree-progressmeter.patch

You beat me. ;) But I was going a bit further and removed the width check (if I'm correct) and set the min-width of the percentage so it's always fully visible.

I also right aligned the element.

What do you think?

Comment 3

[[:MakeMyDay]]

Comment on attachment 8942426 [details] [diff] [review]
tree-progressmeter.patch

Looks good, feel free to take over. The question regarding the string still remains.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8942426 [details] [diff] [review]
tree-progressmeter.patch

Please check the label question in comment 1 too.

Comment 5

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8942426 [details] [diff] [review]
tree-progressmeter.patch

Review of attachment 8942426 [details] [diff] [review]:
-----------------------------------------------------------------

I'm missing the part where the text is introduced, but I assume that has already been there and was just hidden by the progress bar?

::: calendar/base/content/calendar-task-tree.xml
@@ +703,5 @@
>              },
>  
>              // The progress mode for a given cell. This method is only called for
>              // columns of type |progressmeter|.
>              getProgressMode: function(aRow, aCol) {

If we're getting rid of the progressmeter, you can empty this function. You'll need to keep it for the interface, but the rest can be removed. For safety you can always return PROGRESS_NONE.

::: calendar/base/themes/common/calendar-task-tree.css
@@ +117,5 @@
>      -moz-image-region: rect(0 39px 13px 26px);
>  }
>  
> +treecol[anonid="calendar-task-tree-col-percentcomplete"] {
> +  text-align: right;

You should be able to use |text-align: end;| here, then you only need one rule.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: tree-progressmeter.patch

(In reply to Philipp Kewisch [:Fallen]  from comment #5)
> Comment on attachment 8942426 [details] [diff] [review]
> tree-progressmeter.patch
> 
> Review of attachment 8942426 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm missing the part where the text is introduced, but I assume that has
> already been there and was just hidden by the progress bar?

It worked with just removing the progress meter.

> ::: calendar/base/content/calendar-task-tree.xml
> @@ +703,5 @@
> If we're getting rid of the progressmeter, you can empty this function.
> You'll need to keep it for the interface, but the rest can be removed. For
> safety you can always return PROGRESS_NONE.

Done

> ::: calendar/base/themes/common/calendar-task-tree.css
> @@ +117,5 @@
> > +treecol[anonid="calendar-task-tree-col-percentcomplete"] {
> > +  text-align: right;
> 
> You should be able to use |text-align: end;| here, then you only need one
> rule.

Done.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/89ff7aac5875
Remove tree-progressmeter from task view. r=philipp