1430374 - Remove support for treecol/treecell[type=progressmeter]

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Tim Nguyen :ntim]

It seems like we don't use this anywhere:

https://dxr.mozilla.org/mozilla-central/search?q=type%3D%22progressmeter%22&redirect=false
https://dxr.mozilla.org/mozilla-central/search?q=%3A-moz-tree-progressmeter&redirect=false

Comment 1

[Tim Nguyen :ntim]

Looks like SM and TB still use it however: https://dxr.mozilla.org/comm-central/search?q=type%3D%22progressmeter%22&redirect=false

It will be probably be non-trivial to port that to comm-central, since it's deeply implemented in C++ code:

https://dxr.mozilla.org/mozilla-central/source/layout/xul/tree/nsTreeBodyFrame.cpp#3933-4034
https://dxr.mozilla.org/mozilla-central/source/layout/xul/tree/nsTreeBodyFrame.cpp#3418-3434
https://dxr.mozilla.org/mozilla-central/search?q=mozTreeProgressmeter&redirect=false
https://dxr.mozilla.org/mozilla-central/search?q=%3A-moz-tree-progressmeter&redirect=false

Richard, Stefan, could you please look into removing the usages in comm-central? There are only 2, one in SM, one in TB (for the tasks).

Comment 2

[Richard Marti (:Paenglab)]

For TB it's only the calendar that uses the ::-moz-tree-progressmeter. So n-i Philipp and MakeMyDay for looking into it as C++ is nothing I can do.

Comment 3

[Tim Nguyen :ntim]

A feasible quick path may be to use a normal (non-progressmeter) cell, then emulate a progressbar using a linear-gradient (you would need to use JS to apply the styles).

Something like 
::-moz-tree-cell(something) {
  background: linear-gradient(Highlight, Highlight var(--progress), -moz-Field var(--progress));
}

Not sure how feasible that is though.

Comment 4

[Tim Nguyen :ntim]

Another approach would simply be moving away from xul trees for those 2 usages, and using a richlistbox/listbox.

Comment 5

[Dão Gottwald [:dao]]

Trees aren't implemented in XBL so I don't think we can remove any significant XBL for this...

Comment 6

[[:MakeMyDay]]

For the task view, I think it would even be reasonable to get rid of the progressmeter at all by removing the type attribute and this way simply display the percentage value instead. Philipp, any objections?

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

(In reply to [:MakeMyDay] from comment #6)
> For the task view, I think it would even be reasonable to get rid of the
> progressmeter at all by removing the type attribute and this way simply
> display the percentage value instead. Philipp, any objections?

Sound good, let's do it.

Comment 8

[Stefan [:stefanh]]

SM uses "<treecol type="progressmeter ..." in the download manager. I'm a little bit unsure of what would be the best strategy here (comment #3 and comment #4). ni? IanN and frg for suggestions.

Comment 9

[Frank-Rainer Grahl (:frg)]

Probably just remove it. The download manager needs a lot of things fixed. I just add it to the list in Bug 888915. SeaMonkey is broken anyway because of the many removals on short or no notice so just one thing more to fix.

Comment 10

[Tim Nguyen :ntim]

Attachment: Bug 1430374 - Remove support for progressmeter tree cells.

Review commit: https://reviewboard.mozilla.org/r/213146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213146/

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8942881 [details]
Bug 1430374 - Remove support for progressmeter tree cells.

https://reviewboard.mozilla.org/r/213146/#review218978

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8942881 [details]
Bug 1430374 - Remove support for progressmeter tree cells.

https://reviewboard.mozilla.org/r/213146/#review219504

r=me assuming the TB and Seamonkey folks are on board.

Comment 13

[Philipp Kewisch [:Fallen][☁️📆]]

Yes, we've gotten rid of the progressmeter in bug 1430389. Thanks for checking in!

Comment 14

[Tim Nguyen :ntim]

Comment on attachment 8942881 [details]
Bug 1430374 - Remove support for progressmeter tree cells.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213146/diff/1-2/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2f92fe82b0e
Remove support for progressmeter tree cells. r=bz,dao

Comment 16

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f2f92fe82b0e

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ae43fcf7b9ee
comm-central: remove GetProgressMode() methods. rs=bustage-fix

Comment 18

[Ian Neal]

(In reply to Stefan [:stefanh] from comment #8)
> SM uses "<treecol type="progressmeter ..." in the download manager. I'm a
> little bit unsure of what would be the best strategy here (comment #3 and
> comment #4). ni? IanN and frg for suggestions.

Just make a note in bug 888915, thanks.

Comment 19

[Onno Ekker [:nONoNonO UTC+1]]

Can the docs on mdn be updated?
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/treecell
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/treecell.mode
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Tutorial/Styling_a_Tree
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Tree_Widget_Changes
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsITreeView