1430457 - Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[Dão Gottwald [:dao]]

We want to drop support for -moz-border-*-colors, see bug 1429723.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1430457 - Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7.

Review commit: https://reviewboard.mozilla.org/r/212764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212764/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8942497 [details]
Bug 1430457 - Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7.

https://reviewboard.mozilla.org/r/212764/#review218716

I'll grant r+ but I think you should double-check how this looks so we don't accidentally end up increasing the thickness of the visual top border.

::: browser/themes/windows/browser-aero.css:342
(Diff revision 1)
> -    -moz-border-top-colors: @glassActiveBorderColor@ rgba(255,255,255,.6);
> +    padding-top: 1px;
> +    box-shadow: 0 1px 0 rgba(255,255,255,.6) inset;

Testing on a basic webpage on Windows 10 Nightly 59.0a1 (2018-01-10) (64-bit) with 200% DPI, this draws what appears closer to a 2px thick line. .5px is rendering what looks more like a 1px thick line.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> I'll grant r+ but I think you should double-check how this looks so we don't
> accidentally end up increasing the thickness of the visual top border.

We're already using background-image (which scales like box-shadow) on Aero Basic so I don't think it matters much:

https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/browser/themes/windows/browser-aero.css#363

I guess Windows 7 and a high-resolution display aren't a very common combination these days.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43aae260f3f6
Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7. r=jaws

Comment 5

[:Gijs (he/him)]

Does this fix bug 1111138? The commit only mentions windows 7, but this is in a glass selector, and while we changed whether that applies on Windows 10 (I think? I seem to recall seeing we stopped doing that, but I could be wrong...) I expect it still applies on win8, so hopefully bug 1111138 is now fixed?

Comment 6

[Dão Gottwald [:dao]]

-moz-windows-glass only applies on Windows 7, but this won't fix bug 1111138 even there. It makes fixing part of bug 1111138 easier, though: we can stop setting the padding that my patch added.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/43aae260f3f6