Closed Bug 1430457 Opened 2 years ago Closed 2 years ago

Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7

Categories

(Firefox :: Theme, enhancement, P3)

All
Windows Vista
enhancement

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We want to drop support for -moz-border-*-colors, see bug 1429723.
Comment on attachment 8942497 [details]
Bug 1430457 - Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7.

https://reviewboard.mozilla.org/r/212764/#review218716

I'll grant r+ but I think you should double-check how this looks so we don't accidentally end up increasing the thickness of the visual top border.

::: browser/themes/windows/browser-aero.css:342
(Diff revision 1)
> -    -moz-border-top-colors: @glassActiveBorderColor@ rgba(255,255,255,.6);
> +    padding-top: 1px;
> +    box-shadow: 0 1px 0 rgba(255,255,255,.6) inset;

Testing on a basic webpage on Windows 10 Nightly 59.0a1 (2018-01-10) (64-bit) with 200% DPI, this draws what appears closer to a 2px thick line. .5px is rendering what looks more like a 1px thick line.
Attachment #8942497 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> I'll grant r+ but I think you should double-check how this looks so we don't
> accidentally end up increasing the thickness of the visual top border.

We're already using background-image (which scales like box-shadow) on Aero Basic so I don't think it matters much:

https://searchfox.org/mozilla-central/rev/41925c0b6c6d58578690121de439d2a8d3d690f3/browser/themes/windows/browser-aero.css#363

I guess Windows 7 and a high-resolution display aren't a very common combination these days.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43aae260f3f6
Stop using -moz-border-top-colors for the lwtheme faux window border on Windows 7. r=jaws
Does this fix bug 1111138? The commit only mentions windows 7, but this is in a glass selector, and while we changed whether that applies on Windows 10 (I think? I seem to recall seeing we stopped doing that, but I could be wrong...) I expect it still applies on win8, so hopefully bug 1111138 is now fixed?
Flags: needinfo?(dao+bmo)
-moz-windows-glass only applies on Windows 7, but this won't fix bug 1111138 even there. It makes fixing part of bug 1111138 easier, though: we can stop setting the padding that my patch added.
Blocks: 1111138
Flags: needinfo?(dao+bmo)
https://hg.mozilla.org/mozilla-central/rev/43aae260f3f6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.