docker-image files should either not be in skip-unless-changed or added later

RESOLVED FIXED in mozilla59

Status

task
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: glandium, Assigned: dustin)

Tracking

unspecified
mozilla59

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

One thing that the first change in bug 1430005 revealed is that the rewrite_when_to_optimization function adds the taskcluster/docker/$docker-image files to "skip-unless-changed"... but it only does so if the job has a docker image explicitly set, which a lot of jobs don't have. So it would seem this should be added much later, after the last possible place where ['worker']['docker-image'] can be set.

OTOH, it's also wrong, because taskcluster/docker/$docker-image is over-simplifying the files that affect docker images, and aiui, tasks are not optimized anyways if their dependencies (which docker images are) are not optimized. So it would seem this is not necessary at all.
Agreed!
Comment on attachment 8942688 [details]
Bug 1430491: stop depending, incorrectly, on docker images;

https://reviewboard.mozilla.org/r/212946/#review218674
Attachment #8942688 - Flags: review?(mh+mozilla) → review+
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc223a707701
stop depending, incorrectly, on docker images; r=glandium
https://hg.mozilla.org/mozilla-central/rev/cc223a707701
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: TaskCluster → Firefox Build System
Assignee: nobody → dustin
You need to log in before you can comment on or make changes to this bug.