1430491 - docker-image files should either not be in skip-unless-changed or added later

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Mike Hommey [:glandium]]

One thing that the first change in bug 1430005 revealed is that the rewrite_when_to_optimization function adds the taskcluster/docker/$docker-image files to "skip-unless-changed"... but it only does so if the job has a docker image explicitly set, which a lot of jobs don't have. So it would seem this should be added much later, after the last possible place where ['worker']['docker-image'] can be set.

OTOH, it's also wrong, because taskcluster/docker/$docker-image is over-simplifying the files that affect docker images, and aiui, tasks are not optimized anyways if their dependencies (which docker images are) are not optimized. So it would seem this is not necessary at all.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Agreed!

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1430491: stop depending, incorrectly, on docker images;

Review commit: https://reviewboard.mozilla.org/r/212946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/212946/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8942688 [details]
Bug 1430491: stop depending, incorrectly, on docker images;

https://reviewboard.mozilla.org/r/212946/#review218674

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc223a707701
stop depending, incorrectly, on docker images; r=glandium

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cc223a707701