Closed
Bug 1430501
Opened 8 years ago
Closed 7 years ago
JavaScript error: components/devtools-loader.js, TypeError: DebuggerServer.addBrowserActors is not a function
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird60 fixed, thunderbird61 fixed)
RESOLVED
FIXED
Thunderbird 61.0
People
(Reporter: florian, Assigned: jorgk-bmo)
References
Details
Attachments
(1 file, 1 obsolete file)
1.19 KB,
patch
|
Fallen
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
DebuggerServer.addBrowserActors("mail:3pane");
at https://searchfox.org/comm-central/source/mail/components/devtools/devtools-loader.js#70 throws, most likely due to the changes made in bug 1416711.
Assignee | ||
Comment 1•7 years ago
|
||
Right, looks like we need to port something like this:
https://hg.mozilla.org/mozilla-central/rev/e2993f4377faf706eb2cf158721c484a4607422b#l1.12
Assignee | ||
Comment 2•7 years ago
|
||
I'm no expert here, but this fixes the JS error.
Attachment #8957991 -
Flags: review?(philipp)
Comment 3•7 years ago
|
||
Comment on attachment 8957991 [details] [diff] [review]
1430501-addBrowser.patch
Review of attachment 8957991 [details] [diff] [review]:
-----------------------------------------------------------------
You also need to set windowType to mail:3pane.
Attachment #8957991 -
Flags: review?(philipp) → review-
Assignee | ||
Comment 4•7 years ago
|
||
Right, I found this example:
https://hg.mozilla.org/mozilla-central/rev/e2993f4377faf706eb2cf158721c484a4607422b#l81.14
+ let windowType = "navigator:geckoview";
+ DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType });
Attachment #8957991 -
Attachment is obsolete: true
Attachment #8958131 -
Flags: review?(philipp)
Comment 5•7 years ago
|
||
Comment on attachment 8958131 [details] [diff] [review]
1430501-addBrowser.patch (v2)
Review of attachment 8958131 [details] [diff] [review]:
-----------------------------------------------------------------
r+ either way, but one comment:
::: mail/components/devtools/devtools-loader.js
@@ +66,5 @@
> if (!DebuggerServer.initialized) {
> // Initialize and load the toolkit/browser actors
> DebuggerServer.init();
> + let windowType = "mail:3pane";
> + DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType });
I don't think we need an extra variable here, adding it inline fits within 100 characters.
Attachment #8958131 -
Flags: review?(philipp) → review+
Updated•7 years ago
|
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•7 years ago
|
||
Yes, I'll do |windowType: "mail:3pane"|. Thanks.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/526b5080e36a
Port bug 1416711 to TB: Migrate addBrowser to registerActors. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•7 years ago
|
||
Comment on attachment 8958131 [details] [diff] [review]
1430501-addBrowser.patch (v2)
[Triage Comment]
Attachment #8958131 -
Flags: approval-comm-beta+
Assignee | ||
Comment 10•7 years ago
|
||
Beta (TB 60):
https://hg.mozilla.org/releases/comm-beta/rev/3c4321f4a9925db0636704223fccf3fc561a5185
status-thunderbird60:
--- → fixed
Assignee | ||
Updated•7 years ago
|
status-thunderbird61:
--- → fixed
Target Milestone: Thunderbird 60.0 → Thunderbird 61.0
You need to log in
before you can comment on or make changes to this bug.
Description
•