Closed Bug 1430501 Opened 8 years ago Closed 7 years ago

JavaScript error: components/devtools-loader.js, TypeError: DebuggerServer.addBrowserActors is not a function

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird60 fixed, thunderbird61 fixed)

RESOLVED FIXED
Thunderbird 61.0
Tracking Status
thunderbird60 --- fixed
thunderbird61 --- fixed

People

(Reporter: florian, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file, 1 obsolete file)

DebuggerServer.addBrowserActors("mail:3pane"); at https://searchfox.org/comm-central/source/mail/components/devtools/devtools-loader.js#70 throws, most likely due to the changes made in bug 1416711.
Attached patch 1430501-addBrowser.patch (obsolete) — Splinter Review
I'm no expert here, but this fixes the JS error.
Attachment #8957991 - Flags: review?(philipp)
Comment on attachment 8957991 [details] [diff] [review] 1430501-addBrowser.patch Review of attachment 8957991 [details] [diff] [review]: ----------------------------------------------------------------- You also need to set windowType to mail:3pane.
Attachment #8957991 - Flags: review?(philipp) → review-
Right, I found this example: https://hg.mozilla.org/mozilla-central/rev/e2993f4377faf706eb2cf158721c484a4607422b#l81.14 + let windowType = "navigator:geckoview"; + DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType });
Attachment #8957991 - Attachment is obsolete: true
Attachment #8958131 - Flags: review?(philipp)
Comment on attachment 8958131 [details] [diff] [review] 1430501-addBrowser.patch (v2) Review of attachment 8958131 [details] [diff] [review]: ----------------------------------------------------------------- r+ either way, but one comment: ::: mail/components/devtools/devtools-loader.js @@ +66,5 @@ > if (!DebuggerServer.initialized) { > // Initialize and load the toolkit/browser actors > DebuggerServer.init(); > + let windowType = "mail:3pane"; > + DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType }); I don't think we need an extra variable here, adding it inline fits within 100 characters.
Attachment #8958131 - Flags: review?(philipp) → review+
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Yes, I'll do |windowType: "mail:3pane"|. Thanks.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/526b5080e36a Port bug 1416711 to TB: Migrate addBrowser to registerActors. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Hmm, no target 61 yet :-(
Target Milestone: --- → Thunderbird 60.0
Comment on attachment 8958131 [details] [diff] [review] 1430501-addBrowser.patch (v2) [Triage Comment]
Attachment #8958131 - Flags: approval-comm-beta+
Target Milestone: Thunderbird 60.0 → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: