1430501 - JavaScript error: components/devtools-loader.js, TypeError: DebuggerServer.addBrowserActors is not a function

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Florian Quèze [:florian]]

DebuggerServer.addBrowserActors("mail:3pane");
at https://searchfox.org/comm-central/source/mail/components/devtools/devtools-loader.js#70 throws, most likely due to the changes made in bug 1416711.

Comment 1

[Jorg K (CEST = GMT+2)]

Right, looks like we need to port something like this:
https://hg.mozilla.org/mozilla-central/rev/e2993f4377faf706eb2cf158721c484a4607422b#l1.12

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1430501-addBrowser.patch

I'm no expert here, but this fixes the JS error.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8957991 [details] [diff] [review]
1430501-addBrowser.patch

Review of attachment 8957991 [details] [diff] [review]:
-----------------------------------------------------------------

You also need to set windowType to mail:3pane.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1430501-addBrowser.patch (v2)

Right, I found this example:
https://hg.mozilla.org/mozilla-central/rev/e2993f4377faf706eb2cf158721c484a4607422b#l81.14
+      let windowType = "navigator:geckoview";
+      DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType });

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8958131 [details] [diff] [review]
1430501-addBrowser.patch (v2)

Review of attachment 8958131 [details] [diff] [review]:
-----------------------------------------------------------------

r+ either way, but one comment:

::: mail/components/devtools/devtools-loader.js
@@ +66,5 @@
>      if (!DebuggerServer.initialized) {
>        // Initialize and load the toolkit/browser actors
>        DebuggerServer.init();
> +      let windowType = "mail:3pane";
> +      DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType });

I don't think we need an extra variable here, adding it inline fits within 100 characters.

Comment 6

[Jorg K (CEST = GMT+2)]

Yes, I'll do |windowType: "mail:3pane"|. Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/526b5080e36a
Port bug 1416711 to TB: Migrate addBrowser to registerActors. r=philipp

Comment 8

[Jorg K (CEST = GMT+2)]

Hmm, no target 61 yet :-(

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8958131 [details] [diff] [review]
1430501-addBrowser.patch (v2)

[Triage Comment]

Comment 10

[Jorg K (CEST = GMT+2)]

Beta (TB 60):
https://hg.mozilla.org/releases/comm-beta/rev/3c4321f4a9925db0636704223fccf3fc561a5185