JavaScript error: components/devtools-loader.js, TypeError: DebuggerServer.addBrowserActors is not a function

RESOLVED FIXED in Thunderbird 61.0

Status

Product:
Thunderbird
Component:
General
Type:
defect
Status:
RESOLVED FIXED
Opened:
Last year
Updated:
Last year

People

(Reporter: florian, Assigned: jorgk)

Tracking

Version:
unspecified
Target:
Thunderbird 61.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird60 fixed, thunderbird61 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1430501-addBrowser.patch (v2)
1.19 KB, patch
Fallen
: review+
jorgk
: approval-comm-beta+
Details | Diff | Splinter Review
Reporter

Description

•
Last year 
DebuggerServer.addBrowserActors("mail:3pane");
at https://searchfox.org/comm-central/source/mail/components/devtools/devtools-loader.js#70 throws, most likely due to the changes made in bug 1416711.
Assignee

Comment 1

•
Last year 
Right, looks like we need to port something like this:
https://hg.mozilla.org/mozilla-central/rev/e2993f4377faf706eb2cf158721c484a4607422b#l1.12
Assignee

Comment 2

•
Last year
Posted patch 1430501-addBrowser.patch (obsolete) — — Splinter Review 
I'm no expert here, but this fixes the JS error.
Attachment #8957991 - Flags: review?(philipp)

Comment 3

•
Last year 
Comment on attachment 8957991 [details] [diff] [review]
1430501-addBrowser.patch

Review of attachment 8957991 [details] [diff] [review]:
-----------------------------------------------------------------

You also need to set windowType to mail:3pane.
Attachment #8957991 - Flags: review?(philipp) → review-
Assignee

Comment 4

•
Last year 
Right, I found this example:
https://hg.mozilla.org/mozilla-central/rev/e2993f4377faf706eb2cf158721c484a4607422b#l81.14
+      let windowType = "navigator:geckoview";
+      DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType });
Attachment #8957991 - Attachment is obsolete: true
Attachment #8958131 - Flags: review?(philipp)

Comment 5

•
Last year 
Comment on attachment 8958131 [details] [diff] [review]
1430501-addBrowser.patch (v2)

Review of attachment 8958131 [details] [diff] [review]:
-----------------------------------------------------------------

r+ either way, but one comment:

::: mail/components/devtools/devtools-loader.js
@@ +66,5 @@
>      if (!DebuggerServer.initialized) {
>        // Initialize and load the toolkit/browser actors
>        DebuggerServer.init();
> +      let windowType = "mail:3pane";
> +      DebuggerServer.registerActors({ browser: true, root: true, tab: true, windowType });

I don't think we need an extra variable here, adding it inline fits within 100 characters.
Attachment #8958131 - Flags: review?(philipp) → review+
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
 Assignee

Comment 6

•
Last year 
Yes, I'll do |windowType: "mail:3pane"|. Thanks.

Comment 7

•
Last year 
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/526b5080e36a
Port bug 1416711 to TB: Migrate addBrowser to registerActors. r=philipp
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
 Assignee

Comment 8

•
Last year 
Hmm, no target 61 yet :-(
Target Milestone: --- → Thunderbird 60.0
 Assignee

Comment 9

•
Last year 
Comment on attachment 8958131 [details] [diff] [review]
1430501-addBrowser.patch (v2)

[Triage Comment]
Attachment #8958131 - Flags: approval-comm-beta+
 Assignee

Updated

•
Last year
status-thunderbird61: --- → fixed
Target Milestone: Thunderbird 60.0 → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.