1430818 - Crash in URIUtils::ResetWithSource

Status: RESOLVED FIXED

(Core :: XSLT, defect, P2)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is
report bp-a4adffbb-8507-4c63-91b3-9fa440180115.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll URIUtils::ResetWithSource dom/xslt/base/txURIUtils.cpp:48
1 xul.dll txMozillaXSLTProcessor::notifyError dom/xslt/xslt/txMozillaXSLTProcessor.cpp:1122
2 xul.dll txMozillaXSLTProcessor::SetSourceContentModel dom/xslt/xslt/txMozillaXSLTProcessor.cpp:384
3 xul.dll nsXMLContentSink::DidBuildModel dom/xml/nsXMLContentSink.cpp:297
4 xul.dll nsParser::DidBuildModel parser/htmlparser/nsParser.cpp:491
5 xul.dll nsParser::ResumeParse parser/htmlparser/nsParser.cpp:1101
6 xul.dll nsParser::OnStopRequest parser/htmlparser/nsParser.cpp:1475
7 xul.dll nsDocumentOpenInfo::OnStopRequest uriloader/base/nsURILoader.cpp:357
8 xul.dll nsBaseChannel::OnStopRequest netwerk/base/nsBaseChannel.cpp:878
9 xul.dll nsInputStreamPump::OnStateStop netwerk/base/nsInputStreamPump.cpp:704

=============================================================

this is a low volume content crash signature newly appearing in 58.0b16 & 59.0a1.

Comment 1

[Peter Van der Beken [:peterv]]

Might be a regressions from bug 1387427. Probably only happens with an error in an XSLT stylesheet.

Comment 2

[Peter Van der Beken [:peterv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6cbb548e49e895b2161ef58c250c69781b41b3f

Comment 3

[Peter Van der Beken [:peterv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=030e7d5712a94d18e7ff1d575cd638814ab856ff

Comment 4

[Bob Clary [:bc] (inactive)]

bp-9c04ff7b-8220-47f3-a020-2d7fa0180225
xslt error
https://youtuby.xyz/sitemap/sitemap_video5.xml

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: v1.1

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8956751 [details] [diff] [review]
v1.1

So the actual fix is redundant with the fix for bug 1436040, right?  That is, that patch will fix this bug as well.  All that's left here is the testcase and assert fix?

r=me with the commit message adjusted accordingly.  If this lands first, then the commit message should say "We want to create the source fragment before trying to use ...", I would think.

Comment 8

[Peter Van der Beken [:peterv]]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #7)
> So the actual fix is redundant with the fix for bug 1436040, right?  That
> is, that patch will fix this bug as well.  All that's left here is the
> testcase and assert fix?

Well, actually, bug 1436040 applies on top of this.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Oh, I see.  OK, then please adjust per something like the wording at the end of comment 7.

Comment 10

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c3dd78b460b4449ec3935eaaf1f203af93511bb
Bug 1430818 - Crash in URIUtils::ResetWithSource. r=bz.

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3c3dd78b460b

Comment 12

[Julien Cristau [:jcristau]]

Should we uplift this to beta60?

Comment 13

[Peter Van der Beken [:peterv]]

Comment on attachment 8956751 [details] [diff] [review]
v1.1

Approval Request Comment
[Feature/Bug causing the regression]: bug 1387427
[User impact if declined]: crash
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just makes sure we create an object before trying to use it
[String changes made/needed]: none

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 8956751 [details] [diff] [review]
v1.1

crash fix, approved for 60.0b14

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/14286e941bdf