1430846 - Backout bug 1348087 from 59

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P1)

Description

[Molly Howell (she/her) (mostly inactive)]

+++ This bug was initially created as a clone of Bug #1423967 +++

Bug 1348087 is still causing issues and we're not quite going to have those issues fixed for 59. Let's back it out again as we did for 58.

This will also effectively backout bug 1407392, since it depends on bug 1348087.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Attachment: Back out 4 changesets for application update issues

Took me a while, but here's that backout patch.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks Matt, I will move the 59 blocking flag to this bug and keep an eye on it today.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Matt, does this need review ?

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

If it is just backing out what you landed, I guess it doesn't. In that case let's land this on trunk and uplift to beta for another 59.0b1 build.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Per IRC discussion, I'm not going to push this to trunk even though it'll increase the risk of conflicts on subsequent m-c -> m-b syncs between now and next week's version bump.

Comment 6

[Molly Howell (she/her) (mostly inactive)]

Attachment: Followup to fix eslint errors

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b7a84e18b97d (FIREFOX_59b1_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-beta/rev/2c42f976a8bb (FIREFOX_59b1_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-beta/rev/4f3ef7e330c3 (default)

I folded the ESLint fix into the original patch for the graft to default.