Closed Bug 1430896 Opened 5 years ago Closed 5 years ago

SM: Style the wizard-box class since its styling was removed in bug 1430739

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.56 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.56
Tracking Flags:
Tracking Status
seamonkey2.56 --- fixed

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file)

1430896.1.diff
4.24 KB, patch
frg
: review+
Details | Diff | Splinter Review 
It should work fine to add the style rule to the themes communicator.css files. When it comes to importDialog.xul, dialogs.css imports messenger/skin and then communiator.css gets imported.
And I see now that https://hg.mozilla.org/comm-central/rev/9ebd91cfe43b overrides the global.css style rule (I actually don't think that this looks good on Mac, but that's another bug - we could fork the css file to Mac and change that).
Attached patch 1430896.1.diff — — Splinter Review 
The .wizard-box is gone from toolkit, so let's do this now. I rather add it to communicator.css than to dialogs.css.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #8943419 - Flags: review?(frgrahl)
Summary: SM: Style the wizard-box class since it’s styling is removed in bug 1430739 → SM: Style the wizard-box class since its styling was removed in bug 1430739
Comment on attachment 8943419 [details] [diff] [review]
1430896.1.diff

Still trying to build a working SeaMonkey with all the wip patches but looking at the removals and then this patch it looks fine. Thanks.
Attachment #8943419 - Flags: review?(frgrahl) → review+
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/comm-central/rev/7324a6fcde02
SM: Style the wizard-box class since it’s styling was removed in bug 1430739. r=frg
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Seamonkey2.56
status-seamonkey2.56: --- → fixed
You need to log in before you can comment on or make changes to this bug.