1430897 - Revisit CONTENT_LARGE_PAINT_PHASE_WEIGHT

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This is a quick bug to reduce the amount of data we send for CONTENT_LARGE_PAINT_PHASE_WEIGHT, and then send data for small paints as well as large.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, reduce data

This eliminates all but the "r", "dl", and "flb" times. Matt and I think this is reasonable since we have known what the distribution has looked like for a long time.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, reduce data

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, include small paints

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8943052 [details] [diff] [review]
part 2, include small paints

Rebecca, can you do a data review here? This is effectively identical to the CONTENT_LARGE_PAINT_PHASE_WEIGHT probe in Histograms.json, except it accumulates timing for fast paints instead of slow paints.

Comment 5

[[e-mail]]

Comment on attachment 8943052 [details] [diff] [review]
part 2, include small paints

Review of attachment 8943052 [details] [diff] [review]:
-----------------------------------------------------------------

1. Yes, it will have standard Telemetry documentation.
2. Yes, there are the standard Telemetry preferences available to the user.
3. Does not explicitly state a requirement for permanent collection.  
4. This is type 1.
5. Does not explicitly state, but since type 1 data is requested this can be default on in release if required.
6. No new identifiers.
7. Covered by existing policy.
8. Yes, a renewal is needed assuming that this is not for permanent data collection.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/357eed969284
Reduce data sent for CONTENT_LARGE_PAINT_PHASE_WEIGHT. (bug 1430897 part 1, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/978fec77e003
Record paint phase timing for small frames. (bug 1430897 part 2, r=mattwoodrow, data_r=rweiss)

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/357eed969284
https://hg.mozilla.org/mozilla-central/rev/978fec77e003