Closed
Bug 1430919
Opened 6 years ago
Closed 6 years ago
Enable writing mode / RTL support for Grid Inspector
Categories
(DevTools :: Inspector, enhancement, P2)
DevTools
Inspector
Tracking
(firefox59 wontfix, firefox60 fixed)
RESOLVED
FIXED
Firefox 60
People
(Reporter: jryans, Assigned: jryans)
References
(Blocks 1 open bug)
Details
(Whiteboard: [designer-tools])
Attachments
(1 file)
In bug 1303171, we're landing support for writing mode / RTL content in Grid Inspector disabled by default. This bug is for enabling it once we're ready.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8950317 [details] Bug 1430919 - Enable grid highlighter writing mode support. https://reviewboard.mozilla.org/r/219558/#review225322 I think I would prefer to remove this pref. The pref naming is slightly misleading since this only actually affects the grid highlighter so I don't think we should keep it. ::: modules/libpref/init/all.js:1142 (Diff revision 1) > > // GCLI commands directory > pref("devtools.commands.dir", ""); > > +// Common highlighter preferences > +pref("devtools.highlighter.writingModeAdjust", true); I think we should just remove this pref altogether.
Attachment #8950317 -
Flags: review?(gl)
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8950317 [details] Bug 1430919 - Enable grid highlighter writing mode support. https://reviewboard.mozilla.org/r/219558/#review225322 As discussed on IRC, the `getCurrentMatrix` code path is also used by flexbox as well. Anyway, this doesn't appear to magically make writing mode work for flexbox. I filed bug 1437631 about that. Anyway, removing the pref is fine with me.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3284befd8a7622cd978b28e304acf999b0796606
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8950317 [details] Bug 1430919 - Enable grid highlighter writing mode support. https://reviewboard.mozilla.org/r/219558/#review225350
Attachment #8950317 -
Flags: review?(gl) → review+
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/992ac762b498 Enable grid highlighter writing mode support. r=gl
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/992ac762b498
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•