1430919 - Enable writing mode / RTL support for Grid Inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 1303171, we're landing support for writing mode / RTL content in Grid Inspector disabled by default.

This bug is for enabling it once we're ready.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1430919 - Enable grid highlighter writing mode support.

As well as flipping the pref on, this also moves the pref to the common all.js
prefs file because the pref is used by DevTools server code.

Review commit: https://reviewboard.mozilla.org/r/219558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219558/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8950317 [details]
Bug 1430919 - Enable grid highlighter writing mode support.

https://reviewboard.mozilla.org/r/219558/#review225322

I think I would prefer to remove this pref. The pref naming is slightly misleading since this only actually affects the grid highlighter so I don't think we should keep it.

::: modules/libpref/init/all.js:1142
(Diff revision 1)
>  
>  // GCLI commands directory
>  pref("devtools.commands.dir", "");
>  
> +// Common highlighter preferences
> +pref("devtools.highlighter.writingModeAdjust", true);

I think we should just remove this pref altogether.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8950317 [details]
Bug 1430919 - Enable grid highlighter writing mode support.

https://reviewboard.mozilla.org/r/219558/#review225322

As discussed on IRC, the `getCurrentMatrix` code path is also used by flexbox as well.  Anyway, this doesn't appear to magically make writing mode work for flexbox.  I filed bug 1437631 about that.

Anyway, removing the pref is fine with me.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8950317 [details]
Bug 1430919 - Enable grid highlighter writing mode support.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219558/diff/1-2/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3284befd8a7622cd978b28e304acf999b0796606

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8950317 [details]
Bug 1430919 - Enable grid highlighter writing mode support.

https://reviewboard.mozilla.org/r/219558/#review225350

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/992ac762b498
Enable grid highlighter writing mode support. r=gl

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/992ac762b498