1437631 - Flexbox highlighter doesn't honor RTL or Writing Mode

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Similar to writing mode issues with grid, the flexbox highlighter needs changes to properly support writing mode and text direction.

As a hacky test case:

1. Go to http://labs.jensimmons.com/2017/03-003.html
2. Change display: grid to flex for the containers
3. Try the highlighter

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: flexbox_rtl.html

STR

1. Load the test file.
2. Ensure the flexbox highlighter lines up with all flexbox items.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: flexbox_rtl.html

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

STR

1. Load the test file.
2. Ensure the flexbox highlighter lines up with all the horizontal flexbox items.

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Are we gonna support writing mode in another bug?

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Sorry, just saw the other bug. Disregard.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1437631 - Flexbox highlighter doesn't honor RTL or writing mode

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f0ea9200122
Flexbox highlighter doesn't honor RTL or writing mode r=gl

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1f0ea9200122

Comment 10

[Paul_B]

Attachment: Capture.PNG

Vertical and Sideway scenarios: When zooming in at 140% parts of the highlighter are not properly displayed anymore, and when the zoom reaches 150% the highlighter shifts. Is this something that can be fixed here, if the issue is reopened or should I open a different issue addressing the zoom issue specifically? I could not repro the issue for the horizontal scenarios.

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Paul_B from comment #10)
> Created attachment 9021987 [details]
> Capture.PNG
> 
> Vertical and Sideway scenarios: When zooming in at 140% parts of the
> highlighter are not properly displayed anymore, and when the zoom reaches
> 150% the highlighter shifts. Is this something that can be fixed here, if
> the issue is reopened or should I open a different issue addressing the zoom
> issue specifically? I could not repro the issue for the horizontal scenarios.

That is a known issue with all of our highlighters... I don't recall the bug number but it is something we plan to work on some time soon.

Comment 12

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using 60.0a1(2018-02-12), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 65.0b10 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 LTS.
Cheers!