1430923 - Handle EXPORTED_SYMBOLS in ESLint to help define globals in jsm files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

Now that we have glob-based configuration, we should work towards making our module files have no-unused-vars for all variables (including global), rather than just local to functions.

As the first step of this, we should tell ESLint to mark variables exported by "EXPORTED_SYMBOLS" as used.

Additionally, in discussing the various flavours of EXPORTED_SYMBOLS, Ted Campbell tells me that we should not allow `let EXPORTED_SYMBOLS = ...` as strictly speaking the lexical scope should be dead after the script executes (and may impact future work).

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1430923 - Change existing instances of 'let EXPORTED_SYMBOLS = ' to use 'var'.

Review commit: https://reviewboard.mozilla.org/r/213328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213328/

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1430923 - Handle EXPORTED_SYMBOLS in ESLint to help define globals in jsm files, and disallow 'let EXPORTED_SYMBOLS = '.

Review commit: https://reviewboard.mozilla.org/r/213330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213330/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8943058 [details]
Bug 1430923 - Change existing instances of 'let EXPORTED_SYMBOLS = ' to use 'var'.

https://reviewboard.mozilla.org/r/213328/#review219458

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8943059 [details]
Bug 1430923 - Handle EXPORTED_SYMBOLS in ESLint to help define globals in jsm files, and disallow 'let EXPORTED_SYMBOLS = '.

https://reviewboard.mozilla.org/r/213330/#review219460

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5548c012d2b
Change existing instances of 'let EXPORTED_SYMBOLS = ' to use 'var'. r=mossop
https://hg.mozilla.org/integration/autoland/rev/c1895745ba10
Handle EXPORTED_SYMBOLS in ESLint to help define globals in jsm files, and disallow 'let EXPORTED_SYMBOLS = '. r=mossop

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d5548c012d2b
https://hg.mozilla.org/mozilla-central/rev/c1895745ba10