Closed
Bug 1434446
Opened 5 years ago
Closed 5 years ago
[meta] Enable no-unused-vars for global scope on jsm files
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P2)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: meta)
Attachments
(1 file)
Now that we have glob-based configuration, we should work towards making our module files have no-unused-vars for all variables (including global), rather than just local to functions. This can help with finding extra bugs, hidden exports and unused code.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•5 years ago
|
||
Note: the patch here depends on the one in bug 1442377 which is just about to land.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → standard8
|
||
Updated•5 years ago
|
Product: Testing → Firefox Build System
|
||
Comment 3•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8955292 [details] Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. https://reviewboard.mozilla.org/r/224446/#review230758
Attachment #8955292 -
Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8e64a94e635 Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b8e64a94e635
|
||
Updated•5 years ago
|
Target Milestone: --- → mozilla60
|
|
||
Updated•10 months ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•