Closed Bug 1434446 Opened 3 years ago Closed 2 years ago

[meta] Enable no-unused-vars for global scope on jsm files

Categories

(Firefox Build System :: Lint and Formatting, enhancement, P2)

3 Branch
enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: meta)

Attachments

(1 file)

Now that we have glob-based configuration, we should work towards making our module files have no-unused-vars for all variables (including global), rather than just local to functions.

This can help with finding extra bugs, hidden exports and unused code.
Depends on: 1434449
Depends on: 1440711
Depends on: 1440718
Depends on: 1440761
Depends on: 1440804
Depends on: 1442377
Note: the patch here depends on the one in bug 1442377 which is just about to land.
Assignee: nobody → standard8
Product: Testing → Firefox Build System
Comment on attachment 8955292 [details]
Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/.

https://reviewboard.mozilla.org/r/224446/#review230758
Attachment #8955292 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8e64a94e635
Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
https://hg.mozilla.org/mozilla-central/rev/b8e64a94e635
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Keywords: meta
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.