[meta] Enable no-unused-vars for global scope on jsm files

RESOLVED FIXED in Firefox 60

Status

enhancement
P2
normal
RESOLVED FIXED
a year ago
5 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({meta})

3 Branch
mozilla60
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
Now that we have glob-based configuration, we should work towards making our module files have no-unused-vars for all variables (including global), rather than just local to functions.

This can help with finding extra bugs, hidden exports and unused code.
Assignee

Updated

a year ago
Depends on: 1434449
Assignee

Updated

a year ago
Depends on: 1440711
Assignee

Updated

a year ago
Depends on: 1440718
Assignee

Updated

a year ago
Depends on: 1440761
Assignee

Updated

a year ago
Depends on: 1442377
Comment hidden (mozreview-request)
Assignee

Comment 2

a year ago
Note: the patch here depends on the one in bug 1442377 which is just about to land.
Assignee

Updated

a year ago
Assignee: nobody → standard8

Updated

a year ago
Product: Testing → Firefox Build System

Comment 3

a year ago
mozreview-review
Comment on attachment 8955292 [details]
Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/.

https://reviewboard.mozilla.org/r/224446/#review230758
Attachment #8955292 - Flags: review?(dtownsend) → review+

Comment 4

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8e64a94e635
Enable no-unused-vars for global scope on jsm files in browser/. r=mossop

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b8e64a94e635
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Keywords: meta
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.